Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LLM - Use Production Firebase on iOS Nightly Builds #7909

Merged
merged 2 commits into from
Oct 1, 2024
Merged

LLM - Use Production Firebase on iOS Nightly Builds #7909

merged 2 commits into from
Oct 1, 2024

Conversation

cgrellard-ledger
Copy link
Contributor

@cgrellard-ledger cgrellard-ledger commented Sep 25, 2024 •
edited by jira bot
Loading

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • use production firebase on ios nightly builds
    • rename ios local builds from LL [STAGING] to LL[DEV]

📝 Description

Use production firebase on ios nightly builds
Rename ios local builds from LL [STAGING] to LL[DEV]

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@cgrellard-ledger cgrellard-ledger requested a review from a team as a code owner September 25, 2024 15:40
@vercel Vercel
Copy link

vercel bot commented Sep 25, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Oct 1, 2024 8:18am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Oct 1, 2024 8:18am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 1, 2024 8:18am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 1, 2024 8:18am
web-tools ⬜️ Ignored (Inspect) Visit Preview Oct 1, 2024 8:18am

@live-github-bot live-github-bot bot added the mobile Has changes in LLM label Sep 25, 2024
KVNLS
KVNLS previously approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@KVNLS KVNLS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cgrellard-ledger cgrellard-ledger force-pushed the support/llm-ios-nightly-use-prod-firebase branch from 696472f to 733d1b1 Compare September 25, 2024 15:56
@cgrellard-ledger cgrellard-ledger force-pushed the support/llm-ios-nightly-use-prod-firebase branch from 733d1b1 to df432d2 Compare October 1, 2024 08:16
@cgrellard-ledger cgrellard-ledger merged commit 59994d9 into develop Oct 1, 2024
42 of 43 checks passed
@cgrellard-ledger cgrellard-ledger deleted the support/llm-ios-nightly-use-prod-firebase branch October 1, 2024 14:58
@themooneer themooneer mentioned this pull request Oct 2, 2024
Merged
3 tasks
VicAlbr pushed a commit that referenced this pull request Oct 2, 2024
@cgrellard-ledger @VicAlbr
LLM - Use Production Firebase on iOS Nightly Builds (#7909)
d75a002 
* support(llm): use prod firebase on ios nightly builds

* support(llm): mobile-env doc updated
VicAlbr pushed a commit that referenced this pull request Oct 2, 2024
@cgrellard-ledger @VicAlbr
LLM - Use Production Firebase on iOS Nightly Builds (#7909)
eccd45b 
* support(llm): use prod firebase on ios nightly builds

* support(llm): mobile-env doc updated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucasWerey LucasWerey LucasWerey approved these changes

@KVNLS KVNLS KVNLS left review comments

Assignees

@cgrellard-ledger cgrellard-ledger

Labels
mobile Has changes in LLM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cgrellard-ledger @KVNLS @LucasWerey