Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix @ledger/react-native-hid for android tiramisu #7880

Open
wants to merge 27 commits into
base: develop
Choose a base branch
from

Conversation

nicolas-meilan
Copy link

@nicolas-meilan nicolas-meilan commented Sep 24, 2024

#7786

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests. Bugfix must bring non-regression
  • Impact of the changes: the changes impact only the lib @ledger/react-native-hid

πŸ“ Description

Android sdk 34 give the following error when use transporter from the lib @ledger/react-native-hid:
One of RECEIVER_EXPORTED or RECEIVER_NOT_EXPORTED should be specified when a receiver isn't being registered exclusively for system broadcasts.

To fix this bug is needed call getReactApplicationContext() with the Context.RECEIVER_NOT_EXPORTED attribute.

implementation that throw the error: https://github.com/nicolas-meilan/RungeCoin/blob/master/src/web3/wallet/wallet.ts#L210

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Sep 24, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
native-ui-storybook βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Nov 15, 2024 9:08pm
react-ui-storybook βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Nov 15, 2024 9:08pm
web-tools ❌ Failed (Inspect) Nov 15, 2024 9:08pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Nov 15, 2024 9:08pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Nov 15, 2024 9:08pm

Copy link

vercel bot commented Sep 24, 2024

@nicolas-meilan is attempting to deploy a commit to the LedgerHQ Team on Vercel.

A member of the Team first needs to authorize it.

@KVNLS
Copy link
Member

KVNLS commented Sep 27, 2024

Hello @nicolas-meilan, first of all, thank you for your contribution!
Can you resync your fork, please? We had an issue with our CI that we had to fix.
Thank you!

@valpinkman
Copy link
Member

Hello @nicolas-meilan, thank again for your continuous sync of your branch.
Since I do not have an Android Tiramisu to test, it will be @mbertin-ledger that will take over and do the test.

Thanks again for your patience πŸ™

@valpinkman
Copy link
Member

@nicolas-meilan you can stop merging develop into your branch for now. As soon as it's reviewed, we will need one last merge/rebase and you should be good to go

Copy link

github-actions bot commented Nov 3, 2024

There as been no activity on this PR for the last 14 days. Please consider closing this PR.

@github-actions github-actions bot added the Stale label Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fork Pull request base branch comes from a fork. ledgerjs Has changes in the ledgerjs open source libs Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants