Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating locators on success screen and key deletion due to an update on wording #7853 #7877

Merged
merged 3 commits into from
Sep 23, 2024
Merged

Updating locators on success screen and key deletion due to an update on wording #7853 #7877

merged 3 commits into from
Sep 23, 2024

Conversation

mohamedzitouni
Copy link
Contributor

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

This PR is to fix an issue that happened on the CI due to changes on wording for the synchronization success and backup deletion

❓ Context

2fd05ea

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@mohamedzitouni mohamedzitouni requested review from a team as code owners September 23, 2024 14:08
@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Sep 23, 2024
@vercel Vercel
Copy link

vercel bot commented Sep 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Sep 23, 2024 2:43pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Sep 23, 2024 2:43pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Sep 23, 2024 2:43pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Sep 23, 2024 2:43pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Sep 23, 2024 2:43pm

@mohamedzitouni mohamedzitouni merged commit be1d33b into develop Sep 23, 2024
43 of 44 checks passed
@mohamedzitouni mohamedzitouni deleted the fix/ledgersync_update_wording branch September 23, 2024 15:12
qperrot pushed a commit that referenced this pull request Sep 25, 2024
@mohamedzitouni @qperrot
Updating locators on success screen and key deletion due to an update…
e23c7ec 
… on wording #7853 (#7877)

* Updating success text locator due to update on wording #7853

* Update text on locator

* Fixing prettier
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VicAlbr VicAlbr VicAlbr approved these changes

@ypolishchuk-ledger ypolishchuk-ledger ypolishchuk-ledger left review comments

Assignees

@mohamedzitouni mohamedzitouni

Labels
desktop Has changes in LLD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mohamedzitouni @ypolishchuk-ledger @VicAlbr