Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨(lld): add discovery drawer for ordis #7876

Merged
merged 1 commit into from
Sep 23, 2024
Merged

✨(lld): add discovery drawer for ordis #7876

merged 1 commit into from
Sep 23, 2024

Conversation

LucasWerey
Copy link
Contributor

@LucasWerey LucasWerey commented Sep 23, 2024 •
edited
Loading

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • BTC accounts

📝 Description

Add discovery drawer when user comes to btc account and feature has just been activated
useLocalizedUrl for learn more is not used because the academy page only exists in english for ordis
Also view coin control redirects to nothing it will be implemented after
A color is hardcoded to match with btc logo color

For the demo the state is forced so we always see the drawer
https://github.com/user-attachments/assets/8de21056-3997-4ab5-b8d0-c5896986631c

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@vercel Vercel
Copy link

vercel bot commented Sep 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Sep 23, 2024 1:34pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Sep 23, 2024 1:34pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Sep 23, 2024 1:34pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Sep 23, 2024 1:34pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Sep 23, 2024 1:34pm

@live-github-bot live-github-bot bot added desktop Has changes in LLD translations Translation files have been touched labels Sep 23, 2024
@LucasWerey LucasWerey force-pushed the feat/LIVE-12481 branch 4 times, most recently from 262470e to 8cb9563 Compare September 23, 2024 13:29
@LucasWerey LucasWerey marked this pull request as ready for review September 23, 2024 13:30
@LucasWerey LucasWerey requested a review from a team as a code owner September 23, 2024 13:30
themooneer
themooneer approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@themooneer themooneer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@LucasWerey LucasWerey merged commit c95ac37 into develop Sep 23, 2024
42 of 44 checks passed
@LucasWerey LucasWerey deleted the feat/LIVE-12481 branch September 23, 2024 13:52
qperrot pushed a commit that referenced this pull request Sep 25, 2024
@LucasWerey @qperrot
✨(lld): add discovery drawer for ordis (#7876)
39df5c9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themooneer themooneer themooneer approved these changes

Assignees

@LucasWerey LucasWerey

Labels
desktop Has changes in LLD translations Translation files have been touched
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LucasWerey @themooneer