Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CN-508: stake filters for eth staking modal #7870

Merged

Conversation

marcotoniut-ledger
Copy link
Contributor

@marcotoniut-ledger marcotoniut-ledger commented Sep 20, 2024

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • Earn staking modal lists the providers per category and filtering capacity
    • New design to cover rewards' strategy, requirements to stake and improved icons
    • The modal contains a "learn more" banner that redirect to the right resources
    • Add new providers and flags to enable or disable them

📝 Description

This PR includes a redesign and augmentation of the staking modal for both desktop and mobile.

Before:

Screenshot 2024-09-24 at 09 39 11

Simulator Screenshot - iPhone 15 Pro - 2024-09-24 at 10 39 08

After:

Screenshot 2024-10-01 at 23 52 40 Screenshot 2024-10-01 at 23 52 50

Simulator Screenshot - iPhone 15 Pro - 2024-10-02 at 00 12 17

Simulator Screenshot - iPhone 15 Pro - 2024-10-02 at 00 12 28

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Sep 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Oct 7, 2024 1:59pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Oct 7, 2024 1:59pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 7, 2024 1:59pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 7, 2024 1:59pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Oct 7, 2024 1:59pm

@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM ui Has changes in the design system library ledgerjs Has changes in the ledgerjs open source libs translations Translation files have been touched labels Sep 20, 2024
@marcotoniut-ledger marcotoniut-ledger force-pushed the CN-508-stake-filters-for-eth-staking-modal branch 2 times, most recently from fe8833c to 2fbadd3 Compare September 25, 2024 16:40
@marcotoniut-ledger marcotoniut-ledger force-pushed the CN-508-stake-filters-for-eth-staking-modal branch from 1dc2a66 to 7ea2f2d Compare October 1, 2024 02:09
@marcotoniut-ledger marcotoniut-ledger marked this pull request as ready for review October 1, 2024 02:09
@live-github-bot live-github-bot bot added the common Has changes in live-common label Oct 4, 2024
@marcotoniut-ledger marcotoniut-ledger force-pushed the CN-508-stake-filters-for-eth-staking-modal branch 2 times, most recently from c0cfa7f to c43d54b Compare October 4, 2024 11:06
@marcotoniut-ledger marcotoniut-ledger force-pushed the CN-508-stake-filters-for-eth-staking-modal branch from c43d54b to 142e4e6 Compare October 4, 2024 11:14
@marcotoniut-ledger marcotoniut-ledger force-pushed the CN-508-stake-filters-for-eth-staking-modal branch from 142e4e6 to 9e13a7c Compare October 4, 2024 12:32
@marcotoniut-ledger marcotoniut-ledger force-pushed the CN-508-stake-filters-for-eth-staking-modal branch from 3ff2723 to eb4cbdc Compare October 7, 2024 13:59
@marcotoniut-ledger marcotoniut-ledger merged commit 1b3a21d into develop Oct 7, 2024
54 of 57 checks passed
@marcotoniut-ledger marcotoniut-ledger deleted the CN-508-stake-filters-for-eth-staking-modal branch October 7, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common desktop Has changes in LLD ledgerjs Has changes in the ledgerjs open source libs mobile Has changes in LLM translations Translation files have been touched ui Has changes in the design system library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants