Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: workflow permission for a workflow dispatch #7864

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

KVNLS
Copy link
Member

@KVNLS KVNLS commented Sep 20, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Today we can't launch the two edited workflows manually because permissions are not set correctly.
I updated permissions to be aligned with the ones set in the reusable workflow.

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@KVNLS KVNLS self-assigned this Sep 20, 2024
Copy link

vercel bot commented Sep 20, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Sep 20, 2024 0:59am
ledger-live-github-bot ⬜️ Ignored (Inspect) Sep 20, 2024 0:59am
native-ui-storybook ⬜️ Ignored (Inspect) Sep 20, 2024 0:59am
react-ui-storybook ⬜️ Ignored (Inspect) Sep 20, 2024 0:59am
web-tools ⬜️ Ignored (Inspect) Sep 20, 2024 0:59am

@live-github-bot live-github-bot bot added the automation CI/CD stuff label Sep 20, 2024
@KVNLS KVNLS merged commit d84552e into develop Sep 23, 2024
35 of 37 checks passed
@KVNLS KVNLS deleted the fix/permissions-workflow-dispatch branch September 23, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation CI/CD stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant