Update navigation flow for Ledger Sync to handle device prompts and i… #7844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mprove synchronization steps
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 5 Skipped Deployments
|
ypolishchuk-ledger
previously approved these changes
Sep 18, 2024
themooneer
previously approved these changes
Sep 18, 2024
LucasWerey
previously approved these changes
Sep 18, 2024
VicAlbr
previously approved these changes
Sep 18, 2024
mohamedzitouni
dismissed stale reviews from VicAlbr, LucasWerey, themooneer, and ypolishchuk-ledger
via
373ae14
ypolishchuk-ledger
approved these changes
Sep 19, 2024
ypolishchuk-ledger
deleted the
fix/validate-ledgersync-operations-on-device
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…mprove synchronization steps
✅ Checklist
npx changesetwas attached.📝 Description
This PR addresses the issue where automation tests were failing at certain steps due to the inability to detect specific texts on the Ledger device during the synchronization process. The following updates have been made to fix this issue:
Added logic to handle missing text on the device during account synchronization, such as "Make sure", "Connect with", and "Turn on sync?" prompts.
Improved the device interaction flow to ensure these texts are reached and confirmed, allowing the tests to proceed without errors.
Ensured the synchronization process completes successfully and the LedgerSync drawer is properly closed.
📝 Changes:
Modified app.ledgerSync.syncAccounts to handle device interactions using app.speculos.clickNextUntilText and app.speculos.confirmOperationOnDevice.
Improved the flow to catch and interact with texts on the device screen that were previously missed, which caused test failures.
❓ Context
🧐 Checklist for the PR Reviewers