Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛fix(lld): fix export to csv account name #7813

Merged
merged 1 commit into from
Sep 13, 2024
Merged

🐛fix(lld): fix export to csv account name #7813

merged 1 commit into from
Sep 13, 2024

Conversation

LucasWerey
Copy link
Contributor

@LucasWerey LucasWerey commented Sep 13, 2024 •
edited
Loading

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • export to csv

📝 Description

Accounts names were not exported in the csv it's now fixed.

image

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@LucasWerey LucasWerey requested a review from a team as a code owner September 13, 2024 08:46
@vercel Vercel
Copy link

vercel bot commented Sep 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 13, 2024 8:59am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Sep 13, 2024 8:59am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Sep 13, 2024 8:59am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Sep 13, 2024 8:59am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Sep 13, 2024 8:59am

@live-github-bot live-github-bot bot added desktop Has changes in LLD common Has changes in live-common labels Sep 13, 2024
mcayuelas-ledger
mcayuelas-ledger requested changes Sep 13, 2024
View reviewed changes
libs/ledger-live-common/src/csvExport.ts
@@ -65,7 +67,10 @@ const fields: Field[] = [
{
title: "Account Name",
// FIXME: we need to inject wallet state if we want the actual user's account name
cell: (account, parentAccount) => getDefaultAccountName(getMainAccount(account, parentAccount)),
cell: (account, parentAccount, _op, _counterValueCurrency, _countervalueState, walletState) =>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need this 3 ? _op, _counterValueCurrency, _countervalueState

Copy link
Contributor Author

@LucasWerey LucasWerey Sep 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because how it's done today if walletState is at the third place it would be the operation

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed ^^

mcayuelas-ledger
mcayuelas-ledger approved these changes Sep 13, 2024
View reviewed changes
libs/ledger-live-common/src/csvExport.ts
@@ -65,7 +67,10 @@ const fields: Field[] = [
{
title: "Account Name",
// FIXME: we need to inject wallet state if we want the actual user's account name
cell: (account, parentAccount) => getDefaultAccountName(getMainAccount(account, parentAccount)),
cell: (account, parentAccount, _op, _counterValueCurrency, _countervalueState, walletState) =>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed ^^

@LucasWerey LucasWerey merged commit 5762905 into develop Sep 13, 2024
50 of 52 checks passed
@LucasWerey LucasWerey deleted the fix/LIVE-14076 branch September 13, 2024 09:53
@martin-cech
Copy link

Hello, I suspect this caused a change in CSV export that may not be desired.

When I receive USDT on Arbitrum network, the Account Name in export is now "Tether USD". This is not an account name and I have no idea where it came from. Previously the Account Name for this transaction was "Arbitrum 1". This seems more like a bug to me.

Similarly, for USDC on Arbitrum network the Account Name is "USD Coin" (previously also "Arbitrum 1") and for Abitrum itself the Account Name is just "Arbitrum" (previously "Arbitrum 1").

Can you please help me understand this?

@GittyGitGitGitty GittyGitGitGitty mentioned this pull request Oct 15, 2024
Closed
@LucasWerey LucasWerey mentioned this pull request Oct 16, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themooneer themooneer themooneer approved these changes

@mcayuelas-ledger mcayuelas-ledger mcayuelas-ledger approved these changes

Assignees

@LucasWerey LucasWerey

Labels
common Has changes in live-common desktop Has changes in LLD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LucasWerey @martin-cech @themooneer @mcayuelas-ledger