Ledger Sync - Display error when scanning invalid QR Code #7800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Skipped Deployments
|
live-github-bot
bot
added
mobile
There was a problem hiding this comment.
You need to add it also in apps/ledger-live-mobile/src/newArch/features/Accounts/screens/AddAccount/components/StepFlow.tsx
Comment on lines
+80
to
+86
| if (data.match(/host=([0-9A-Fa-f]+)/)) { | ||
| this.setState({ | ||
| error: new ScannedNewImportQrCode(), | ||
| progress: 0, | ||
| }); | ||
| screen("", AnalyticsPage.ScannedIncompatibleApps, { source: "Account Import Sync" }); | ||
| } |
There was a problem hiding this comment.
Do we have to do it in the catch block? Couldn't we perform the check at the beginning instead?
There was a problem hiding this comment.
It's the analytics event for the error that is triggered in the catch (the setState({ error: new ScannedNewImportQrCode() }) ).
As it's handled by the generic error component I had to trigger the analytics here
cgrellard-ledger
force-pushed
the
bugfix/ledger-sync-scan-invalid-qr-code
branch
from
eef5c0b
to
9171311
Compare
mcayuelas-ledger
requested changes
Sep 12, 2024
cgrellard-ledger
force-pushed
the
bugfix/ledger-sync-scan-invalid-qr-code
branch
from
9171311
to
1c53f10
Compare
mcayuelas-ledger
approved these changes
Sep 12, 2024
cgrellard-ledger
deleted the
bugfix/ledger-sync-scan-invalid-qr-code
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
Replace this text by a clear and concise description of what this pull request is about and why it is needed. Be sure to explain the problem you're addressing and the solution you're proposing.
For libraries, you can add a code sample of how to use it.
For bugfixes, you can explain the previous behavior and how it was fixed.
In case of visual features, please attach screenshots or video recordings to demonstrate the changes.
❓ Context
🧐 Checklist for the PR Reviewers