Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LIVE-13976] Bugfix - Allow missing coinRef with EIP-712 filters V2 #7779

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

lambertkevin
Copy link
Contributor

@lambertkevin lambertkevin commented Sep 9, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • no more throws when a token isn't in CAL

πŸ“ Description

When a token isn't in CAL, we can't send the correct descriptors to the device (PROVIDE_ERC20_TOKEN_INFOS) which is supposed to return the token "index" it has in memory. Due to this not being possible, we were throwing an error missing coinRef without ever sending anymore APDUs.
This behavior will be changed in the next ethereum nano app, and the app is now expecting the coinRef even if the token descriptor hasn't been provided.

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@lambertkevin lambertkevin requested a review from a team as a code owner September 9, 2024 13:28
Copy link

vercel bot commented Sep 9, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Sep 9, 2024 1:28pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Sep 9, 2024 1:28pm
native-ui-storybook ⬜️ Ignored (Inspect) Sep 9, 2024 1:28pm
react-ui-storybook ⬜️ Ignored (Inspect) Sep 9, 2024 1:28pm
web-tools ⬜️ Ignored (Inspect) Sep 9, 2024 1:28pm

@live-github-bot live-github-bot bot added the ledgerjs Has changes in the ledgerjs open source libs label Sep 9, 2024
@lambertkevin lambertkevin merged commit 9abf63b into develop Sep 9, 2024
57 of 60 checks passed
@lambertkevin lambertkevin deleted the bugfix/allow-missing-coinRef branch September 9, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ledgerjs Has changes in the ledgerjs open source libs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants