Feature/llm card #7774
Merged
Feature/llm card #7774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 5 Skipped Deployments
|
live-github-bot
bot
added
mobile
chrisduma-ledger
requested changes
Sep 10, 2024
apps/ledger-live-mobile/src/components/RootNavigator/CardLiveAppNavigator.tsx
Outdated
Show resolved
Hide resolved
| ); | ||
| }; | ||
|
|
||
| export default function CardAppNavigator(_props?: Record<string, unknown>) { |
There was a problem hiding this comment.
same as above
Also please update the type to use an actual type instead of Record<string, unknown>
apps/ledger-live-mobile/src/components/RootNavigator/CardLiveAppNavigator.tsx
Outdated
Show resolved
Hide resolved
Comment on lines
28
to
32
| ..._props.route, | ||
| params: { | ||
| goToURL: _props.route.params?.goToURL, | ||
| lastScreen: _props.route.params?.lastScreen, | ||
| platform: _props.route.params?.platform || defaultPlatform, |
There was a problem hiding this comment.
This piece is a little unclear to me, why are we spreading the route object but then assigning onto the params values from the object we just spread?
There was a problem hiding this comment.
Refactor this part of the code, ensuring that we only fill in parameters that have not been set.
apps/ledger-live-mobile/src/components/RootNavigator/CardLiveAppNavigator.tsx
Outdated
Show resolved
Hide resolved
chrisduma-ledger
previously approved these changes
Sep 13, 2024
chrisduma-ledger
approved these changes
Sep 13, 2024
KVNLS
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
Implement Ledger CarD Web in LLM
❓ Context
https://ledgerhq.atlassian.net/browse/LIVE-13970
https://ledgerhq.atlassian.net/browse/LIVE-13741
🧐 Checklist for the PR Reviewers