Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix approve operations tron #7762

Merged
merged 3 commits into from
Sep 12, 2024

Conversation

hedi-edelbloute
Copy link
Member

@hedi-edelbloute hedi-edelbloute commented Sep 5, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes: tron operation list
    • ...

πŸ“ Description

Approve smart contract method executions broke history graph / operation list on Tron

This PR fixes this and edit operation type to approval (also, it moves from token account to parent)

Before :
image

After:
image

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@hedi-edelbloute hedi-edelbloute requested a review from a team as a code owner September 5, 2024 15:54
Copy link

vercel bot commented Sep 5, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
web-tools βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Sep 12, 2024 8:32am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Sep 12, 2024 8:32am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Sep 12, 2024 8:32am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Sep 12, 2024 8:32am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Sep 12, 2024 8:32am

Copy link
Contributor

@Wozacosta Wozacosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

Quick questions:

@hedi-edelbloute
Copy link
Member Author

Good!

Quick questions:

Maybe we could do the same thing for those types of tokens indeed, but the initial goal of this PR is a bugfix so I think we should discuss it with product

@hedi-edelbloute hedi-edelbloute force-pushed the support/fix-approve-operations-tron branch from 8817e56 to 695ca79 Compare September 12, 2024 08:26
@hedi-edelbloute hedi-edelbloute merged commit 156b370 into develop Sep 12, 2024
49 of 50 checks passed
@hedi-edelbloute hedi-edelbloute deleted the support/fix-approve-operations-tron branch September 12, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants