Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

more receive flows : checking warning messages #7730

Merged
merged 2 commits into from
Sep 11, 2024
Merged

more receive flows : checking warning messages #7730

merged 2 commits into from
Sep 11, 2024

Conversation

bharamboure-ledger
Copy link
Contributor

@bharamboure-ledger bharamboure-ledger commented Sep 3, 2024 •
edited
Loading

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.

📝 Description

Receive flows: more coins & checking warning messages

https://ledgerhq.atlassian.net/browse/B2CQA-1551
https://ledgerhq.atlassian.net/browse/B2CQA-652

❓ Context

https://ledgerhq.atlassian.net/browse/QAA-99

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@vercel Vercel
Copy link

vercel bot commented Sep 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Sep 11, 2024 3:50pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Sep 11, 2024 3:50pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Sep 11, 2024 3:50pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Sep 11, 2024 3:50pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Sep 11, 2024 3:50pm

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Sep 3, 2024
@bharamboure-ledger bharamboure-ledger mentioned this pull request Sep 3, 2024
Closed
@bharamboure-ledger bharamboure-ledger merged commit 7c3657c into develop Sep 11, 2024
38 of 39 checks passed
@bharamboure-ledger bharamboure-ledger deleted the support/receive-flows-qaa-99 branch September 11, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcayuelas-ledger mcayuelas-ledger mcayuelas-ledger approved these changes

@abdurrahman-ledger abdurrahman-ledger abdurrahman-ledger approved these changes

@ypolishchuk-ledger ypolishchuk-ledger ypolishchuk-ledger approved these changes

Assignees

@bharamboure-ledger bharamboure-ledger

Labels
desktop Has changes in LLD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bharamboure-ledger @ypolishchuk-ledger @abdurrahman-ledger @mcayuelas-ledger