Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moonbeam/Moonriver update logos and colors #7566

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

albertov19
Copy link
Contributor

@albertov19 albertov19 commented Aug 8, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:

πŸ“ Description

Updated the Moonbeam/Moonriver logos and colors to follow the new Moonbeam/Moonriver brand guidelines

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@albertov19 albertov19 requested review from a team as code owners August 8, 2024 20:43
Copy link

vercel bot commented Aug 8, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
web-tools βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Sep 23, 2024 1:06pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Sep 23, 2024 1:06pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Sep 23, 2024 1:06pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Sep 23, 2024 1:06pm

Copy link

vercel bot commented Aug 8, 2024

@albertov19 is attempting to deploy a commit to the LedgerHQ Team on Vercel.

A member of the Team first needs to authorize it.

@live-github-bot live-github-bot bot added desktop Has changes in LLD ui Has changes in the design system library ledgerjs Has changes in the ledgerjs open source libs fork Pull request base branch comes from a fork. labels Aug 8, 2024
@albertov19
Copy link
Contributor Author

Hey @ypolishchuk-ledger any updates here πŸ˜„ thanks in advance

Copy link

github-actions bot commented Sep 7, 2024

There as been no activity on this PR for the last 14 days. Please consider closing this PR.

@github-actions github-actions bot added the Stale label Sep 7, 2024
@albertov19
Copy link
Contributor Author

Waiting on review from the Ledger Team :)

@github-actions github-actions bot removed the Stale label Sep 10, 2024
@albertov19
Copy link
Contributor Author

Hey all - any updates here? Thanks in advance

@Wozacosta
Copy link
Contributor

Hey there, the svgs you submitted have some extra tags that make them not render (at all).

SCR-20240916-rrmy

Could you maybe try to export them as plain svg (Im guessing you used inkscape or something similar as there are sodipopi tags in the svg https://wiki.inkscape.org/wiki/Inkscape_SVG_vs._plain_SVG).

At the very least for Moonriver, as I was able to clean the Moonbeam svg and make it display properly.

FYI you can use this tool to validate the svgs beforehand without having to build Ledger Live: https://live.ledger.tools/svg-icons.
It catches common tags are missing attributes that could result in the logos not displaying properly.

VicAlbr
VicAlbr previously approved these changes Sep 18, 2024
@albertov19
Copy link
Contributor Author

@Wozacosta I pushed new SVGs following your suggestions, thanks!

@VicAlbr @bharamboure-ledger please check again πŸ™

@Wozacosta
Copy link
Contributor

Checked again, didn't display correctly, here's the versions I modified that make them displayable in desktop:

MOVR
GLMR

@albertov19
Copy link
Contributor Author

Ah @Wozacosta but then the checker is not correct. Your SVGS have just a viewBox and an image tag that has the base64 content while the ones I've been working with have the geometric definitions with circle and path, etc. Nevertheless, your image does not pass the provided SVG checker tool.

Unsure how to proceed as the latest images I tested pass the checker.

@albertov19
Copy link
Contributor Author

@Wozacosta Hey, I hope you are well. Any thoughts on my post above? Would love to get this merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD fork Pull request base branch comes from a fork. ledgerjs Has changes in the ledgerjs open source libs ui Has changes in the design system library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants