Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LLM - fix crash on experimental settings screen #7144

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

cgrellard-ledger
Copy link
Contributor

@cgrellard-ledger cgrellard-ledger commented Jun 19, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:

πŸ“ Description

Removing the KeyboardView from the Experimental settings screen to fix a crash happening since the upgrade to React Native 0.73

Here is a github issue of this exact bug : facebook/react-native#42939

This isn't ideal as the keyboard will now go over the fields in the bottom of the screen but it fixes the crash while we implement a better solution

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@cgrellard-ledger cgrellard-ledger requested a review from a team as a code owner June 19, 2024 16:35
Copy link

vercel bot commented Jun 19, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Jun 19, 2024 4:35pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Jun 19, 2024 4:35pm
native-ui-storybook ⬜️ Ignored (Inspect) Jun 19, 2024 4:35pm
react-ui-storybook ⬜️ Ignored (Inspect) Jun 19, 2024 4:35pm
web-tools ⬜️ Ignored (Inspect) Jun 19, 2024 4:35pm

@live-github-bot live-github-bot bot added the mobile Has changes in LLM label Jun 19, 2024
@cgrellard-ledger cgrellard-ledger merged commit d9c4124 into develop Jun 20, 2024
38 of 40 checks passed
@cgrellard-ledger cgrellard-ledger deleted the bugfix/live-12996 branch June 20, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants