Skip to content

chore(readme): file structure section update and typos #5769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 18, 2023
Merged

chore(readme): file structure section update and typos #5769

merged 4 commits into from
Dec 18, 2023

Conversation

aboissiere-ledger
Copy link
Contributor

📝 Description

  • LLD Readme Typos
  • Visual Studio Code Configuration: Removal of content already available through provided link (risk of drifting away)
  • File Structure Section Update

❓ Context

✅ Checklist

Pull Requests must pass the CI and be code reviewed. Set as Draft if the PR is not ready.

  • npx changeset was attached.
  • Covered by automatic tests.

  • [ ] Impact of the changes:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@aboissiere-ledger aboissiere-ledger requested a review from a team as a code owner December 15, 2023 16:11
@vercel Vercel
Copy link

vercel bot commented Dec 15, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Dec 18, 2023 9:57am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Dec 18, 2023 9:57am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Dec 18, 2023 9:57am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Dec 18, 2023 9:57am
web-tools ⬜️ Ignored (Inspect) Visit Preview Dec 18, 2023 9:57am

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Dec 15, 2023
aboissiere-ledger
aboissiere-ledger commented Dec 15, 2023
View reviewed changes
apps/ledger-live-desktop/README.md
@@ -74,35 +74,11 @@ pnpm build:lld

If you are using [Visual Studio Code](https://code.visualstudio.com/) IDE, we provide a [default debug configuration](https://github.com/LedgerHQ/ledger-live/tree/develop/.vscode/launch.json) that you can use to debug the main and renderer processes of the application.

```json
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This content is already provided by the link above. No need to hard code it here as we'll never think about updating both the file and the readme

@aboissiere-ledger aboissiere-ledger merged commit 37a5274 into develop Dec 18, 2023
@aboissiere-ledger aboissiere-ledger deleted the support/LIVE-10671-typo branch December 18, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KVNLS KVNLS KVNLS approved these changes

Assignees

@aboissiere-ledger aboissiere-ledger

Labels
desktop Has changes in LLD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aboissiere-ledger @KVNLS