🐛(lld): typo + fees url (#8239)

LedgerHQ · Oct 29, 2024 · f63c04f · f63c04f
1 parent 464cb79
commit f63c04f
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 7 deletions.
diff --git a/.changeset/wicked-trains-ring.md b/.changeset/wicked-trains-ring.md
@@ -0,0 +1,5 @@
+---
+"ledger-live-desktop": patch
+---
+
+update max estimated fee support url and typo
diff --git a/apps/ledger-live-desktop/src/config/urls.ts b/apps/ledger-live-desktop/src/config/urls.ts
@@ -56,7 +56,7 @@ export const urls = {
   contactSupport: "https://support.ledger.com/",
   contactSupportWebview: "https://support.ledger.com/article/4423020306705-zd",
   whatIsARecoveryPhrase: "https://www.ledger.com/academy/crypto/what-is-a-recovery-phrase",
-  feesMoreInfo: "https://support.ledger.com/?redirect=false",
+  feesMoreInfo: "https://support.ledger.com/article/360021039173-zd",
   feesEIP1559MoreInfo: "https://support.ledger.com/article/6018110754845-zd",
   feesTron: "https://support.ledger.com/article/6331588714141-zd",
   recipientAddressInfo: "https://support.ledger.com/article/4404389453841-zd",

diff --git a/apps/ledger-live-desktop/static/i18n/en/app.json b/apps/ledger-live-desktop/static/i18n/en/app.json
@@ -2289,7 +2289,7 @@
       "amount": {
         "title": "Amount",
         "banner": "Maximum spendable amount is",
-        "fees": "Max estimated fee",
+        "fees": "Learn more about fees",
         "standard": "Standard",
         "advanced": "Advanced",
         "nftQuantity": "Quantity"

diff --git a/apps/ledger-live-desktop/tests/specs/services/confirmTransaction.spec.ts b/apps/ledger-live-desktop/tests/specs/services/confirmTransaction.spec.ts
@@ -108,7 +108,7 @@ test("Confirm Transaction modals @smoke", async ({ page }) => {
     });
 
     // Step Fees
-    await expect(page.getByText("Max estimated fee")).toBeVisible();
+    await expect(page.getByText(/learn more about fees/i)).toBeVisible();
     await modal.continueToSignTransaction();
 
     // Step Recipient
@@ -165,7 +165,7 @@ test("Confirm Transaction modals @smoke", async ({ page }) => {
     });
 
     // Step Fees
-    await expect(page.getByText("Max estimated fee")).toBeVisible();
+    await expect(page.getByText(/learn more about fees/i)).toBeVisible();
     await expect(page.getByText("Approve token")).toBeVisible();
     await modal.continueToSignTransaction();
 
@@ -225,7 +225,7 @@ test("Confirm Transaction modals @smoke", async ({ page }) => {
     });
 
     // Step Fees
-    await expect(page.getByText("Max estimated fee")).toBeVisible();
+    await expect(page.getByText(/learn more about fees/i)).toBeVisible();
     await expect(page.getByText("Approve token")).toBeVisible();
     await modal.continueToSignTransaction();
 

diff --git a/apps/ledger-live-desktop/tests/specs/services/wallet-api.spec.ts b/apps/ledger-live-desktop/tests/specs/services/wallet-api.spec.ts
@@ -465,7 +465,7 @@ test("Wallet API methods @smoke", async ({ page }) => {
     });
 
     // Step Fees
-    await expect(page.getByText("Max estimated fee")).toBeVisible();
+    await expect(page.getByText(/learn more about fees/i)).toBeVisible();
     await modal.continueToSignTransaction();
 
     // Step Recipient
@@ -504,7 +504,7 @@ test("Wallet API methods @smoke", async ({ page }) => {
     });
 
     // Step Fees
-    await expect(page.getByText("Max estimated fee")).toBeVisible();
+    await expect(page.getByText(/learn more about fees/i)).toBeVisible();
     await modal.continueToSignTransaction();
 
     // Step Recipient