chore: cleanup the previous usage of 'learn' feature flag

LedgerHQ · Mar 5, 2024 · 7e26827 · 7e26827
1 parent 5a5cff1
commit 7e26827
Show file tree

Hide file tree

Showing 10 changed files with 3 additions and 183 deletions.
diff --git a/apps/ledger-live-desktop/src/renderer/Default.tsx b/apps/ledger-live-desktop/src/renderer/Default.tsx
@@ -62,7 +62,6 @@ const Swap2 = lazy(() => import("~/renderer/screens/exchange/Swap2"));
 
 const Market = lazy(() => import("~/renderer/screens/market"));
 const MarketCoinScreen = lazy(() => import("~/renderer/screens/market/MarketCoinScreen"));
-const Learn = lazy(() => import("~/renderer/screens/learn"));
 const WelcomeScreenSettings = lazy(
   () => import("~/renderer/screens/settings/WelcomeScreenSettings"),
 );
@@ -316,9 +315,6 @@ export default function Default() {
                               render={withSuspense(MarketCoinScreen)}
                             />
                             <Route path="/market" render={withSuspense(Market)} />
-                            <FeatureToggle featureId="learn">
-                              <Route path="/learn" render={withSuspense(Learn)} />
-                            </FeatureToggle>
                           </Switch>
                         </Page>
                         <Drawer />

diff --git a/apps/ledger-live-desktop/src/renderer/components/MainSideBar/index.tsx b/apps/ledger-live-desktop/src/renderer/components/MainSideBar/index.tsx
@@ -266,10 +266,6 @@ const MainSideBar = () => {
     push("/card");
     trackEntry("card");
   }, [push, trackEntry]);
-  const handleClickLearn = useCallback(() => {
-    push("/learn");
-    trackEntry("learn");
-  }, [push, trackEntry]);
   const handleClickDashboard = useCallback(() => {
     push("/");
     trackEntry("/portfolio");
@@ -398,18 +394,6 @@ const MainSideBar = () => {
                   isActive={location.pathname.startsWith("/market")}
                   collapsed={secondAnim}
                 />
-                <FeatureToggle featureId="learn">
-                  <SideBarListItem
-                    id="learn"
-                    label={t("sidebar.learn")}
-                    icon={IconsLegacy.NewsMedium}
-                    iconSize={20}
-                    iconActiveColor="wallet"
-                    isActive={location.pathname.startsWith("/learn")}
-                    onClick={handleClickLearn}
-                    collapsed={secondAnim}
-                  />
-                </FeatureToggle>
                 <SideBarListItem
                   id={"accounts"}
                   label={t("sidebar.accounts")}

diff --git a/apps/ledger-live-desktop/src/renderer/screens/learn/index.tsx b/apps/ledger-live-desktop/src/renderer/screens/learn/index.tsx
diff --git a/apps/ledger-live-desktop/static/i18n/en/app.json b/apps/ledger-live-desktop/static/i18n/en/app.json
@@ -275,7 +275,6 @@
   },
   "sidebar": {
     "card": "Card",
-    "learn": "Learn",
     "menu": "Menu",
     "stars": "Starred accounts",
     "accounts": "Accounts",
@@ -5539,11 +5538,11 @@
     },
     "WrongDeviceForAccountPayout": {
       "title": "Something went wrong",
-      "description":  "This receiving account does not belong to your device. Please change and retry."
+      "description": "This receiving account does not belong to your device. Please change and retry."
     },
     "WrongDeviceForAccountRefund": {
       "title": "Something went wrong",
-      "description":  "This receiving account does not belong to your device for the refund. Please change and retry."
+      "description": "This receiving account does not belong to your device for the refund. Please change and retry."
     },
     "DeviceAppVerifyNotSupported": {
       "title": "App update required",

diff --git a/apps/ledger-live-mobile/src/components/RootNavigator/BaseNavigator.tsx b/apps/ledger-live-mobile/src/components/RootNavigator/BaseNavigator.tsx
@@ -61,7 +61,6 @@ import {
 } from "~/screens/BleDevicePairingFlow";
 
 import PostBuyDeviceScreen from "~/screens/PostBuyDeviceScreen";
-import LearnWebView from "~/screens/Learn/index";
 import { useNoNanoBuyNanoWallScreenOptions } from "~/context/NoNanoBuyNanoWall";
 import PostBuyDeviceSetupNanoWallScreen from "~/screens/PostBuyDeviceSetupNanoWallScreen";
 import CurrencySettings from "~/screens/Settings/CryptoAssets/Currencies/CurrencySettings";
@@ -194,11 +193,6 @@ export default function BaseNavigator() {
           }}
           {...noNanoBuyNanoWallScreenOptions}
         />
-        <Stack.Screen
-          name={ScreenName.LearnWebView}
-          component={LearnWebView}
-          options={{ headerShown: false }}
-        />
         <Stack.Screen
           name={NavigatorName.ExploreTab}
           component={ExploreTabNavigator}

diff --git a/apps/ledger-live-mobile/src/locales/en/common.json b/apps/ledger-live-mobile/src/locales/en/common.json
@@ -2182,15 +2182,7 @@
     "discover": "Discover",
     "nanoX": "Nano X",
     "market": "Market",
-    "earn": "Earn",
-    "learn": "Learn"
-  },
-  "learn": {
-    "pageTitle": "learn",
-    "sectionShows": "Shows",
-    "sectionVideo": "Video",
-    "sectionPodcast": "Podcast",
-    "sectionArticles": "Articles"
+    "earn": "Earn"
   },
   "portfolio": {
     "totalBalance": "Total balance",

diff --git a/apps/ledger-live-mobile/src/navigation/DeeplinksProvider.tsx b/apps/ledger-live-mobile/src/navigation/DeeplinksProvider.tsx
@@ -322,7 +322,6 @@ const linkingOptions = () => ({
                * ie: "ledgerlive://learn"
                */
               [ScreenName.Newsfeed]: "newsfeed",
-              [ScreenName.Learn]: "learn",
             },
           },
           [NavigatorName.ImportAccounts]: {

diff --git a/apps/ledger-live-mobile/src/screens/Learn/index.tsx b/apps/ledger-live-mobile/src/screens/Learn/index.tsx
diff --git a/libs/ledger-live-common/src/featureFlags/defaultFeatures.ts b/libs/ledger-live-common/src/featureFlags/defaultFeatures.ts
@@ -106,7 +106,6 @@ export const DEFAULT_FEATURES: Features = {
   newsfeedPage: initFeature(),
   swapWalletApiPartnerList: initFeature(),
   stakePrograms: initFeature(),
-  learn: initFeature(),
   receiveStakingFlowConfigDesktop: initFeature(),
   brazePushNotifications: initFeature(),
   walletNftGallery: initFeature(),

diff --git a/libs/ledgerjs/packages/types-live/src/feature.ts b/libs/ledgerjs/packages/types-live/src/feature.ts
@@ -125,7 +125,6 @@ export type CurrencyFeatures = {
  * @dev Add features here.
  */
 export type Features = CurrencyFeatures & {
-  learn: Feature_Learn;
   brazePushNotifications: Feature_BrazePushNotifications;
   brazeLearn: Feature_BrazeLearn;
   llmNewDeviceSelection: Feature_LlmNewDeviceSelection;
@@ -282,11 +281,6 @@ export type Feature_ReceiveStakingFlowConfigDesktop = Feature<{
   };
 }>;
 
-export type Feature_Learn = Feature<{
-  mobile: { url: string };
-  desktop: { url: string };
-}>;
-
 export type Feature_Storyly = Feature<{
   stories: {
     [key in StorylyInstanceID]: StorylyInstanceType;