🐛 (clear-signing-tester) [NO-ISSUE]: Install userland undici to avoid Node 24 crash#1603
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Contributor
Contributor
There was a problem hiding this comment.
Pull request overview
This PR mitigates a Node 24 crash affecting the apps/clear-signing-tester CLI by forcing the process to use a patched userland undici implementation for the global fetch stack.
Changes:
- Add
undici@^8.5.0toapps/clear-signing-testerdependencies and lock it inpnpm-lock.yaml. - Introduce
src/setup/installUndici.tsto install userland undici globally (fetch/Headers/Request/Response) at startup. - Import this setup module first in both Solana and Ethereum CLI entrypoints to ensure all HTTP calls use the patched client.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pnpm-lock.yaml | Locks the new undici dependency (and associated lockfile reshaping) needed for the runtime patch. |
| apps/clear-signing-tester/package.json | Adds undici dependency for the clear-signing tester app. |
| apps/clear-signing-tester/src/setup/installUndici.ts | New startup-side-effect module that installs userland undici globally. |
| apps/clear-signing-tester/src/cli/SolanaTransactionTesterCli.ts | Ensures undici installation runs before other imports in Solana CLI. |
| apps/clear-signing-tester/src/cli/EthereumTransactionTesterCli.ts | Ensures undici installation runs before other imports in Ethereum CLI. |
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
50
to
+54
| "ethers": "catalog:", | ||
| "inversify": "catalog:", | ||
| "rxjs": "catalog:", | ||
| "semver": "catalog:" | ||
| "semver": "catalog:", | ||
| "undici": "^8.5.0" |
aussedatlo
force-pushed
the
fix/no-issue-solana-cs-tester-undici-crash
branch
from
July 3, 2026 12:06
699d131 to
6337b75
Compare
|
fAnselmi-Ledger
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Install userland undici to avoid a Node 24 crash in the clear-signing-tester.
Node 24 bundles undici 7.x, whose HTTP/1 parser throws an uncatchable
AssertionErroron socket end under response-body backpressure (nodejs/undici#5360), crashing the cs-tester mid-run. This installs the patched userland undici (8.x, fix from nodejs/undici#5389) over the globalfetchstack at the CLI entrypoints, so every HTTP call (Solana RPC, context module, metadata service) routes through the fixed client.❓ Context
AssertionError [ERR_ASSERTION]: false == true at Parser.finishafter the toolchain bump from Node 20 → 24 (🔧 (repo) [NO-ISSUE]: Update toolchain #1582).✅ Checklist
apps/clear-signing-testerapp (not a published package).undici@^8.5.0toapps/clear-signing-tester.src/setup/installUndici.tsand imports it first in both the Solana and Ethereum CLI entrypoints to replace the global fetch stack with the patched undici.Made with Cursor