Swd #20
Open
Swd #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kingofpayne
reviewed
Aug 5, 2024
kingofpayne
reviewed
Aug 5, 2024
kingofpayne
reviewed
Aug 5, 2024
kingofpayne
reviewed
Aug 5, 2024
kingofpayne
reviewed
Aug 5, 2024
kingofpayne
reviewed
Sep 2, 2024
kingofpayne
reviewed
Sep 2, 2024
kingofpayne
reviewed
Sep 2, 2024
kingofpayne
reviewed
Sep 3, 2024
kingofpayne
reviewed
Sep 3, 2024
kingofpayne
reviewed
Sep 3, 2024
…nabled, as per review comment
kingofpayne
reviewed
Sep 3, 2024
kingofpayne
reviewed
Sep 9, 2024
kingofpayne
reviewed
Sep 9, 2024
kingofpayne
reviewed
Sep 9, 2024
kingofpayne
reviewed
Sep 9, 2024
fpga-arch/bsv/SWD.bsv
Outdated
|
|
||
| // ONLY do something if there is a valid command registered, and if | ||
| // the user is not currently writing to some register. | ||
| rule do_idle ((state == IDLE) && (bus_write == 0) && isValid(cmd)); |
Contributor
There was a problem hiding this comment.
I think bus_write == 0 should not be in the condition here. As long as cmd is valid, the SWD peripheral can start working.
In particular, the host may be talking with another Scaffold peripheral at the same time, and this shall not prevent the SWD from working.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a SWD controller to the FPGA architecture, and exposes it through the python API.