Skip to content

Commit

Permalink
tmp
Browse files Browse the repository at this point in the history
```
Running tests:
1 ambiguities found. To get a list, set `broken = false`.
Ambiguity JuliaStats#1
frule(::ChainRulesCore.RuleConfig, args...) in ChainRulesCore at /home/runner/.julia/packages/ChainRulesCore/I1EbV/src/rules.jl:64
frule(::Any, ::typeof(Distributions.logpdf), d::Distributions.Uniform, x::Real) in Distributions.DistributionsChainRulesCoreExt at /home/runner/work/Distributions.jl/Distributions.jl/ext/DistributionsChainRulesCoreExt/univariate/continuous/uniform.jl:1

Possible fix, define
  frule(::ChainRulesCore.RuleConfig, ::typeof(Distributions.logpdf), ::Distributions.Uniform, ::Real)

Aqua: Test Failed at /home/runner/.julia/packages/Aqua/tHrmY/src/ambiguities.jl:78
  Expression: iszero(num_ambiguities)
Stacktrace:
 [1] macro expansion
   @ /opt/hostedtoolcache/julia/1.8.5/x64/share/julia/stdlib/v1.8/Test/src/Test.jl:464 [inlined]
 [2] _test_ambiguities(packages::Vector{Base.PkgId}; broken::Bool, kwargs::Base.Pairs{Symbol, Union{}, Tuple{}, NamedTuple{(), Tuple{}}})
   @ Aqua ~/.julia/packages/Aqua/tHrmY/src/ambiguities.jl:78
```
  • Loading branch information
LebedevRI committed Sep 17, 2024
1 parent b219803 commit 1ad3513
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 19 deletions.
32 changes: 17 additions & 15 deletions .github/workflows/CI.yml
Original file line number Diff line number Diff line change
@@ -1,13 +1,7 @@
name: CI

on:
pull_request:
push:
branches:
- master
tags: '*'
workflow_dispatch:
merge_group:
on: push


concurrency:
# Skip intermediate builds: always.
Expand All @@ -23,13 +17,26 @@ jobs:
fail-fast: false
matrix:
version:
- '1.3'
- '1'
- '1.10'
- '1.9'
- '1.8'
- '1.7'
- '1.6'
- pre
os:
- ubuntu-latest
- macos-latest
- windows-latest
include:
- version: '1.7'
os: macos-12
- version: '1.6'
os: macos-12
exclude:
- version: '1.7'
os: macos-latest
- version: '1.6'
os: macos-latest
steps:
- uses: actions/checkout@v4
- uses: julia-actions/setup-julia@v2
Expand All @@ -47,11 +54,6 @@ jobs:
Pkg.instantiate()'
- run: julia --project=perf perf/samplers.jl
- uses: julia-actions/julia-processcoverage@v1
- uses: codecov/codecov-action@v4
with:
token: ${{ secrets.CODECOV_TOKEN }} # required
fail_ci_if_error: true
files: lcov.info
docs:
name: Documentation
runs-on: ubuntu-latest
Expand Down
5 changes: 1 addition & 4 deletions test/aqua.jl
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,10 @@ import Aqua
Aqua.test_all(
Distributions;
ambiguities = false,
# On older Julia versions, installed dependencies are quite old
# Thus unbound type parameters show up that are fixed in newer versions
unbound_args = VERSION >= v"1.6",
)
# Tests are not reliable on older Julia versions and
# show ambiguities in loaded packages
if VERSION >= v"1.6"
if VERSION >= v"1.9"
Aqua.test_ambiguities(Distributions)
end
end

0 comments on commit 1ad3513

Please sign in to comment.