Skip to content

🎨 Palette: Improve settings form accessibility#12

Merged
LebToki merged 1 commit intomainfrom
palette-ux-settings-a11y-7501139349646504985
Mar 17, 2026
Merged

🎨 Palette: Improve settings form accessibility#12
LebToki merged 1 commit intomainfrom
palette-ux-settings-a11y-7501139349646504985

Conversation

@LebToki
Copy link
Copy Markdown
Owner

@LebToki LebToki commented Mar 17, 2026

💡 What: Added missing for attributes to <label>s and corresponding ids to <input> elements in the Settings form (public/settings.php). Also added aria-label and title attributes to the icon-only password visibility toggle buttons.
🎯 Why: To improve keyboard accessibility, ensure screen readers can announce form fields correctly, and increase the clickable target area (clicking the label now focuses the input). The buttons now provide context to assistive technologies and users hovering over them.
Accessibility: Form controls are now explicitly associated with their labels, and icon-only buttons have descriptive accessible names.
📸 Before/After: Visually identical, but functionally improved for assistive tech.


PR created automatically by Jules for task 7501139349646504985 started by @LebToki

Added missing `for` attributes to labels and `id` attributes to inputs in `public/settings.php` to properly associate them, improving screen reader support and clickable area.
Added `aria-label` and `title` attributes to icon-only password visibility toggle buttons.
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@codemaker-ai-app
Copy link
Copy Markdown

Hello from @codemakerai.

CodeMaker AI GitHub App integration.

Usage:

@codemakerai [command or prompt]

Assistant

All Assistant features are supported in GitHub. Assistant can answer general questions as well as questions directly
related to code. It also has code editing capabilities.

@codemakerai assistant prompt - the assistant prompt
@codemakerai prompt - the assistant prompt. Alias to assistant command.

Commands

Pull Request Commands - commands that can be posted as comments on the pull request:

@codemakerai help - prints this help message
@codemakerai review process - process the most recent code review and all it's comments
@codemakerai generate code [codepath] - generate code for all files in pull request, or only for matching code path.
@codemakerai generate docs [codepath] - generate documentation for all files in pull request, or only for matching code path.
@codemakerai replace code [codepath] - replace code for all files in pull request, or only for matching code path.
@codemakerai replace docs [codepath] - replace documentation for all files in pull request, or only for matching code path.
@codemakerai fix syntax - fixes the syntax in all files
@codemakerai commit undo - removes the most recent commit

Pull Request Code Review Commands - commands that can be posted as comments on the code review i.e. "Files changed" tab:

@codemakerai assistant prompt - the assistant prompt
@codemakerai explain - explains the code
@codemakerai review - reviews the code

Triggers

To automatically trigger certain actions on pull requests you can create and use the following GitHub labels.

codemakerai-pull-request-generate-documentation - automatically generates comments/documentation on Pull Request creation.
codemakerai-pull-request-syntax-autocorrection - automatically corrects syntax on Pull Request creation.
codemakerai-pull-request-review-process - automatically processes code review comments on Pull Request Review submission.

For in depth explanation of the features, please consult https://docs.codemaker.ai

In case of any issues please report them to https://community.codemaker.ai

@LebToki LebToki marked this pull request as ready for review March 17, 2026 16:23
@LebToki LebToki merged commit 906a7d6 into main Mar 17, 2026
1 check passed
@LebToki LebToki deleted the palette-ux-settings-a11y-7501139349646504985 branch March 17, 2026 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant