-
-
Notifications
You must be signed in to change notification settings - Fork 200
✨ feat: add workflow to test all solutions #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ feat: add workflow to test all solutions #41
Conversation
JoshuaKGoldberg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great start!
|
Thanks @JoshuaKGoldberg , I have made changes.. I am currently looking into the prettier for shell scripts, It would make a lot of sense.. |
|
Hey @JoshuaKGoldberg ✨ , I have added the prettier plugin for shell scripts.. It was just an Can you review now ? Thanks ✨ ❤️ . |
|
Looks like I have to ignore the |
|
Ah done ! 😺 |
JoshuaKGoldberg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Close 😁 can we prettify the husky things?
I guess we can prettify husky files in the CI 🤔 right ? |
|
Yeah I don't see any reason not to. Like, if it's gitignored anyway, users won't see the impact of it. So we can get one less config line to worry about. |
|
True @JoshuaKGoldberg ✨ |
JoshuaKGoldberg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the merges from main 😅 just wanted to make sure the solutions work. This is looking great!
I am confused about the prettier.yml addition though? Other than that, no issues from me!
JoshuaKGoldberg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Glorious. A great change and you persevered despite me blatantly not understanding. Thanks again! 🔥
|
@all-contributors please add @fuadop for infrastructure setup ...hoping this works! 🤞 https://allcontributors.org/docs/en/bot/usage |
|
I've put up a pull request to add @fuadop! 🎉 |
PR Checklist
Overview
test:solutionsscripts in all nested project folder containing a package.json. cc @JoshuaKGoldberg