Skip to content

Conversation

@fuadop
Copy link
Contributor

@fuadop fuadop commented May 29, 2022

PR Checklist

Overview

  • Adds script to workflows to run all test:solutions scripts in all nested project folder containing a package.json. cc @JoshuaKGoldberg

Copy link
Contributor

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start!

@fuadop
Copy link
Contributor Author

fuadop commented May 29, 2022

Thanks @JoshuaKGoldberg , I have made changes.. I am currently looking into the prettier for shell scripts, It would make a lot of sense..

@fuadop
Copy link
Contributor Author

fuadop commented May 29, 2022

Hey @JoshuaKGoldberg ✨ , I have added the prettier plugin for shell scripts.. It was just an npm install --save-dev prettier-plugin-sh 😅 .

Can you review now ? Thanks ✨ ❤️ .

@fuadop fuadop requested a review from JoshuaKGoldberg May 29, 2022 16:44
@fuadop
Copy link
Contributor Author

fuadop commented May 29, 2022

Looks like I have to ignore the .husky folder from prettier😅 . Some husky configuration files that aren't on the repo.. that get added during npm install are being prettier-ed check because of the new plugin.

@fuadop
Copy link
Contributor Author

fuadop commented May 29, 2022

Ah done ! 😺

Copy link
Contributor

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Close 😁 can we prettify the husky things?

@fuadop
Copy link
Contributor Author

fuadop commented May 29, 2022

Close 😁 can we prettify the husky things?

I guess we can prettify husky files in the CI 🤔 right ?

@JoshuaKGoldberg
Copy link
Contributor

Yeah I don't see any reason not to. Like, if it's gitignored anyway, users won't see the impact of it. So we can get one less config line to worry about.

@fuadop
Copy link
Contributor Author

fuadop commented May 29, 2022

True @JoshuaKGoldberg

Copy link
Contributor

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the merges from main 😅 just wanted to make sure the solutions work. This is looking great!

I am confused about the prettier.yml addition though? Other than that, no issues from me!

@fuadop fuadop requested a review from JoshuaKGoldberg May 29, 2022 20:29
Copy link
Contributor

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glorious. A great change and you persevered despite me blatantly not understanding. Thanks again! 🔥

@JoshuaKGoldberg JoshuaKGoldberg merged commit 764003a into LearningTypeScript:main May 29, 2022
@JoshuaKGoldberg
Copy link
Contributor

@all-contributors please add @fuadop for infrastructure setup

...hoping this works! 🤞 https://allcontributors.org/docs/en/bot/usage

@allcontributors
Copy link
Contributor

@JoshuaKGoldberg

I've put up a pull request to add @fuadop! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Run all solution scripts in CI

2 participants