Skip to content

Fix typos in some project details #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Fix typos in some project details #279

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions projects/declaration-files/global-travels/01-passport-declarations/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@

Ah, thank you for volunteering.
Since you're on an international flight, we will need to validate your passport before you can leave the designated travel area.
But: our systems are quite legacy and we've lost the type annotations for our passport checking system.
But our systems are quite legacy and we've lost the type annotations for our passport checking system.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one technically isn't a typo (the : is intentional) but on re-read I like this updated version more. 😄


Could you please add in the missing global declarations so our `checkPassport` function can pass type-checking please?
Could you please add in the missing global declarations so our `checkPassport` function can pass type-checking?
It runs fine as-is -no need to change its runtime behavior- but we would all feel better with no TypeScript compiler complaints.

## Files
Expand Down
2 changes: 1 addition & 1 deletion projects/declaration-files/global-travels/02-unexpected-methods/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

Well folks, it seems like we've made an unexpected stop... somewhere.
We're not sure where.
Will the TypeScript enthusiast we spoke to earlier please to the front of the plane again?
Will the TypeScript enthusiast we spoke to earlier please come to the front of the plane again?

Thanks for volunteering a second time.
We've found this odd script, `./index.ts`, that seems to make use of Array and String methods not present in our JavaScript environment.
Expand Down
2 changes: 1 addition & 1 deletion projects/declaration-files/global-travels/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ Hello, and welcome!
ברוך הבא!

We are so glad you're elected to travel with Type Air.
We hope your trip through the type-safe skies is peasant.
We hope your trip through the type-safe skies is pleasant.
By the way, if there a software developer flying with us, please report to the front of the plane.
We have some files we'd like your assistance with.

Expand Down
2 changes: 1 addition & 1 deletion projects/generics/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

_Learning TypeScript_'s **Generics** chapter covers making classes, functions, interfaces, and type aliases "generic" by allowing them to work with type parameters:

- Using type parameters to represent types different between uses of a construct
- Using type parameters to represent different types between uses of a construct
- Providing explicit or implicit type arguments when calling generic functions
- Using generic interfaces to represent generic object types
- Adding type parameters to classes, and how that impacts their types
Expand Down