Move Request NoPendingDownloads #95
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
The
onVariablesChangedAndNoDownloadsPendingcallback is executed twice on Start. The callback is executed fromVarCache.Updateand immediately fromLeanplumRequest.NoPendingDownloadsif there are no pending downloads.The latter is executed on iOS and Android only if a
downloadFilerequest is started. This differs from Unity Native where the handler is executed immediately when added to theLeanplumRequestif there are no Pending Downloads.Implementation
Move the
LeanplumRequest.NoPendingDownloadsso it is executed only when there are pending downloads. Otherwise, the callback is executed fromVarCache.Update, resulting in only 1 execution at Start.Testing steps
Tested using an Asset File Variable to trigger download request at Start.
Is this change backwards-compatible?