Re-export L9Subdomain, remove dead R class #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add L9Subdomain to package exports and __all__ so users can import it directly via `from leakix import L9Subdomain` - Remove R class from response.py: it extends AbstractResponse without implementing abstract methods, making it unusable Closes #31
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
L9Subdomainto__init__.pyimports and__all__for public API accessRclass fromresponse.py— it extendsAbstractResponsewithout implementing abstract methods and cannot be instantiatedTest plan
from leakix import L9SubdomainworksCloses #31