Prevent errors from occurring when the message data is malformed. #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On some builds the dice roll will fail due to the messageData object not having the update method. This will cause the dice roll to fail without any information being passed back to the end user. I found on the latest V9 update, this issue was becoming quite prevalent as my world and a friendly world encountered it. This change makes it so even if it fails, the user will get a console log to see what went wrong.
|
@Lazrius I modified your changes to tackle the problem in a different way, as just logging an error to the console isn't necessarily equivalent to raising an error. Can you test out the changes? |
|
I have tested and the error did not occur on both installs that I tested, so that looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some builds the dice roll will fail due to the messageData object not having the update method. This will cause the dice roll to fail without any information being passed back to the end user. I found on the latest V9 update, this issue was becoming quite prevalent as my world and a friend's world encountered it. This change makes it so even if it fails, the user will get a console log to see what went wrong.