Sanity check of buttons length before calling indexes #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome stuff @yohanboniface I should have thought of this while making the change :| |
jacobtoye
added a commit
that referenced
this pull request
Jan 17, 2013
Sanity check of buttons length before calling indexes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My use case is that enabling/disabling handlers can be done from UI by users in Leaflet.Storage (demo here), so one can disable all the handlers.
I also can do some checks on my side, but: 1. I think this sanity check doesn't cost; 2. I'm using the container even if no handler is enabled.
Thanks!
Yohan