Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misaligned icons and actions links #267

Closed
wants to merge 1 commit into from
Closed

Fix misaligned icons and actions links #267

wants to merge 1 commit into from

Conversation

brunob
Copy link
Contributor

@brunob brunob commented Jan 26, 2014

This fix the problem with leaflet 0.7.x

@jacobtoye
Copy link
Member

I can't seem to see the misalignment? Would you upload a screenshot that illustrates the issue.

See http://leaflet.github.io/Leaflet.draw/

@brunob
Copy link
Contributor Author

brunob commented Jan 28, 2014

Ha, the problem is only visible on Firefox 26, sorry i should have test on more browser before opening this PR. Anyway here is a screenshot that show the difference with Firefox on the left and Chromium on the right :

align

The bug appears when the class leaflet-touch is applied on map container, which is done by default on Firefox but not on Chromium.

@brunob
Copy link
Contributor Author

brunob commented Jan 28, 2014

For info, the leaflet-touch class is only added with Firefox 26 on ubuntu (not with FF 26 on win$ or osx).

@jacobtoye
Copy link
Member

Does the latest addition #269 fix the rendering issue?

@brunob
Copy link
Contributor Author

brunob commented Feb 4, 2014

Yes it does :) Thanks @alanshaw for the fix !

Closing the PR, but wondering if it's a bug or not that Leaflet applies the leaflet-touch class to map container on Firefox 26 with Ubuntu ?

@brunob brunob closed this Feb 4, 2014
@brunob brunob deleted the patch-1 branch February 4, 2014 08:30
@jacobtoye
Copy link
Member

@brunob yeah it does seem to be a bug with Leaflet. I don't have Ubuntu with a desktop to test. You could open an issue in the Leaflet github repo.

@brunob
Copy link
Contributor Author

brunob commented Feb 5, 2014

@jacobtoye done Leaflet/Leaflet#2437 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants