-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new credentials endpoints and update part of old endpoints documentation #127
Add new credentials endpoints and update part of old endpoints documentation #127
Conversation
2 similar comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! But there are some points to review
- We should not use
{{url}}
in our examples as we already use api.withleaf.io - The payload for all post endpoints is wrong, please review then
There are also some other points marked in their respective place.
``` | ||
|
||
</TabItem> | ||
</Tabs> | ||
|
||
### `GET /climate-field-view-credentials` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we include a deprecated tag in these headers? Something like a tag or a strikethrough
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first section talks about which endpoints are deprecated. For the body of the page, I think it is easier to restructure the whole page to separate deprecated endpoints from the new ones instead of tagging individually. But if you and/or product thinks every endpoint should have a tag I can add it, sure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your right!
No description provided.