Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

As a user I want a method on al entities, forms and senses that gives me the URI to the entity #516

Closed
dpriskorn opened this issue Feb 24, 2023 · 4 comments · Fixed by #537
Closed

As a user I want a method on al entities, forms and senses that gives me the URI to the entity #516

dpriskorn opened this issue Feb 24, 2023 · 4 comments · Fixed by #537
Assignees
@LeMyst

Comments

@dpriskorn
Copy link
Contributor

For example if I download a lexeme with lexeme.get() and iterate through the forms of a lexeme I want to be able to call form.uri and get e.g. http://www.wikidata.org/wiki/Lexeme:L1#F1 as a string.

This should of course use the wikibase config to generate the uri
LeMyst added a commit that referenced this issue Apr 24, 2023
@LeMyst
Add get_entity_url()
3ebf4ac 
Close #516
@LeMyst LeMyst mentioned this issue Apr 24, 2023
Merged
@LeMyst
Copy link
Owner

LeMyst commented Apr 24, 2023

Does #537 help you?

@dpriskorn
Copy link
Contributor Author

Does #537 help you?

Only partly. Does it support sense and form URLs also?

@LeMyst
Copy link
Owner

LeMyst commented Apr 25, 2023

I'm trying to find out more information about the url entity for the declaration/meaning/form and whether it is perennial.

@dpriskorn
Copy link
Contributor Author

dpriskorn commented Apr 26, 2023 •
edited
Loading

I don't understand. Did you see my implementation?
Just add the form ID or sense ID to the Wikidata url.
They don't have URIs like entities.

LeMyst added a commit that referenced this issue Apr 30, 2023
@LeMyst
Add get_entity_url() (#537)
61485c2 
* Add get_entity_url()

Close #516

* Ignore unsupported mypy

Check python/mypy#6185
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LeMyst LeMyst

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add get_entity_url() LeMyst/WikibaseIntegrator
2 participants
@LeMyst @dpriskorn