review changes (Azure#34480)

LazaUK · Feb 28, 2024 · b2c66cb · b2c66cb
1 parent 404b60e
commit b2c66cb
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 17 deletions.
diff --git a/sdk/ml/azure-ai-ml/azure/ai/ml/entities/_monitoring/compute.py b/sdk/ml/azure-ai-ml/azure/ai/ml/entities/_monitoring/compute.py
@@ -26,7 +26,7 @@ def __init__(
         self.instance_type = instance_type
 
     def _to_rest_object(self) -> MonitorServerlessSparkCompute:
-        self.validate()
+        self._validate()
         return MonitorServerlessSparkCompute(
             runtime_version=self.runtime_version,
             instance_type=self.instance_type,
@@ -42,7 +42,7 @@ def _from_rest_object(cls, obj: MonitorServerlessSparkCompute) -> "ServerlessSpa
             instance_type=obj.instance_type,
         )
 
-    def validate(self) -> None:
+    def _validate(self) -> None:
         if self.runtime_version != "3.3":
             msg = "Compute runtime version must be 3.3"
             err = ValidationException(

diff --git a/sdk/ml/azure-ai-ml/azure/ai/ml/entities/_monitoring/thresholds.py b/sdk/ml/azure-ai-ml/azure/ai/ml/entities/_monitoring/thresholds.py
@@ -108,9 +108,6 @@ def _get_default_thresholds(cls) -> "NumericalDriftMetrics":
     def defaults(cls) -> "NumericalDriftMetrics":
         return cls._get_default_thresholds()
 
-    def get_name_and_threshold(self) -> Tuple:
-        return self._find_name_and_threshold()
-
 
 class CategoricalDriftMetrics(RestTranslatableMixin):
     """Categorical Drift Metrics
@@ -204,15 +201,15 @@ def __init__(
     def _to_rest_object(self) -> DataDriftMetricThresholdBase:
         thresholds = []
         if self.numerical:
-            num_metric_name, num_threshold = self.numerical.get_name_and_threshold()
+            num_metric_name, num_threshold = self.numerical._find_name_and_threshold()
             thresholds.append(
                 NumericalDataDriftMetricThreshold(
                     metric=snake_to_camel(num_metric_name),
                     threshold=num_threshold,
                 )
             )
         if self.categorical:
-            cat_metric_name, cat_threshold = self.categorical.get_name_and_threshold()
+            cat_metric_name, cat_threshold = self.categorical._find_name_and_threshold()
             thresholds.append(
                 CategoricalDataDriftMetricThreshold(
                     metric=snake_to_camel(cat_metric_name),
@@ -279,15 +276,15 @@ def __init__(
     def _to_rest_object(self) -> PredictionDriftMetricThresholdBase:
         thresholds = []
         if self.numerical:
-            num_metric_name, num_threshold = self.numerical.get_name_and_threshold()
+            num_metric_name, num_threshold = self.numerical._find_name_and_threshold()
             thresholds.append(
                 NumericalPredictionDriftMetricThreshold(
                     metric=snake_to_camel(num_metric_name),
                     threshold=num_threshold,
                 )
             )
         if self.categorical:
-            cat_metric_name, cat_threshold = self.categorical.get_name_and_threshold()
+            cat_metric_name, cat_threshold = self.categorical._find_name_and_threshold()
             thresholds.append(
                 CategoricalPredictionDriftMetricThreshold(
                     metric=snake_to_camel(cat_metric_name),
@@ -404,10 +401,6 @@ def _get_default_thresholds(cls) -> "DataQualityMetricsNumerical":
             out_of_bounds_rate=0.0,
         )
 
-    @classmethod
-    def defaults(cls) -> "DataQualityMetricsNumerical":
-        return cls._get_default_thresholds()
-
 
 class DataQualityMetricsCategorical(RestTranslatableMixin):
     """Data Quality Categorical Metrics
@@ -480,10 +473,6 @@ def _get_default_thresholds(cls) -> "DataQualityMetricsCategorical":
             out_of_bounds_rate=0.0,
         )
 
-    @classmethod
-    def defaults(cls) -> "DataQualityMetricsCategorical":
-        return cls._get_default_thresholds()
-
 
 class DataQualityMetricThreshold(MetricThreshold):
     """Data quality metric threshold