Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatability changes to work with arb nitro #4

Merged
merged 45 commits into from
May 31, 2024

Conversation

afkbyte
Copy link
Collaborator

@afkbyte afkbyte commented May 30, 2024

  • Add functions to perform IFFT/FFT on fr arrays and the polynomial
  • Bring in ethen's versioning changes for compatibility with the arbitrum arbitrator
  • Adds from_padded_bytes to blob.rs to be able to construct blobs with data that is already padded according to DA specs
  • Adds the field form to the polynomial struct of type
pub enum PolynomialFormat {
    InCoefficientForm,
    InEvaluationForm,
}

Uses these fields to determine if the G1 points should be IFFT'd when computing the kzg commitment or proof

Currently Blocked: Builds but can't run cargo test to test new functions, there's some versioning issue here that I'm struggling to resolve.
Screenshot 2024-05-30 at 7 49 30 PM

EDIT: tests run in CI and are passing now, still can't get them running locally though.

Cargo.toml Outdated Show resolved Hide resolved
src/blob.rs Outdated Show resolved Hide resolved
src/kzg.rs Outdated Show resolved Hide resolved
src/polynomial.rs Outdated Show resolved Hide resolved
src/polynomial.rs Outdated Show resolved Hide resolved
src/polynomial.rs Outdated Show resolved Hide resolved
@afkbyte afkbyte marked this pull request as ready for review May 31, 2024 17:19
@afkbyte afkbyte requested a review from anupsv May 31, 2024 17:21
Copy link
Collaborator

@anupsv anupsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More tests will be added in next PR since there's a problem with the rust environment being used and unable to run tests locally.

@afkbyte afkbyte merged commit 5667c66 into Layr-Labs:master May 31, 2024
1 check passed
@afkbyte afkbyte deleted the afk/g1-iift-optional branch May 31, 2024 23:39
@afkbyte afkbyte restored the afk/g1-iift-optional branch May 31, 2024 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants