Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Altda devnet monitoring #11

Draft
wants to merge 27 commits into
base: develop
Choose a base branch
from
Draft

Altda devnet monitoring #11

wants to merge 27 commits into from

Commits on Oct 7, 2024

  1. feat: add sol-style-malformed-require locally (ethereum-optimism#12340)

    Adds sol-style-malformed-require to local semgrep and actually
    fixes the rule so that it works. Fixes a couple of findings that
    the rule found.
    smartcontracts authored Oct 7, 2024
    Configuration menu
    Copy the full SHA
    981ee6a View commit details
    Browse the repository at this point in the history
  2. contracts-bedrock: cleanup FeeVault (ethereum-optimism#12338)

    * contracts-bedrock: cleanup `FeeVault`
    
    Updates the `FeeVault` to follow modern conventions used in the repo
    by moving to usage of interfaces rather than implementations. Also
    moves the `FeeVault` into the `L2` package as its only really useful
    on L2. This is meant to reduce the diff for the Stanard L2 Genesis
    by breaking up the refactor into its own small PR.
    
    * contracts: update semver-lock
    
    * semver-lock: fixup
    
    * cleanup: refactor
    
    * lint: fix
    
    * snapshots: regenerate
    
    * interface check: ignore fee vaults
    
    There is an issue with normalization of enums when they are return
    values
    tynes authored Oct 7, 2024
    Configuration menu
    Copy the full SHA
    b460aa2 View commit details
    Browse the repository at this point in the history
  3. contracts-bedrock: fixes OptimismMintableERC721Factory test (ethere…

    …um-optimism#12306)
    
    * contracts-bedrock: fixes `OptimismMintableERC721Factory` test
    
    This contract is only used as a predeploy so it should be tested based
    on the L2 genesis generation setup. Ensures that the address is stored
    and labeled as part of in memory test setup, as well as updates the
    tests to work based on the predeploy.
    
    This is a small refactor to make future Standard L2 genesis work more
    simple.
    
    Also includes a small ABI fix to the `OptimismMintableERC721Factory`
    since this contract has not been updated to decouple immutable naming
    conventions from its ABI.
    
    * snapshots: update
    
    * checks: fix
    
    * lint: fix
    
    * typo: fix
    tynes authored Oct 7, 2024
    Configuration menu
    Copy the full SHA
    35bbd80 View commit details
    Browse the repository at this point in the history
  4. feat: add sol-style-malformed-revert locally (ethereum-optimism#12341)

    Adds sol-style-malformed-revert to local semgrep and fixes the
    rule so that it actually works. Fixes a couple of findings that
    the updated rule discovered.
    smartcontracts authored Oct 7, 2024
    Configuration menu
    Copy the full SHA
    6d874d5 View commit details
    Browse the repository at this point in the history
  5. feat(ct): add checks for unused imports (ethereum-optimism#12348)

    A few things in this commit:
    - Adds a new check for unused imports in contracts
    - Cleans up contracts based on that check
    - Removes several files that aren't being used anymore
    smartcontracts authored Oct 7, 2024
    Configuration menu
    Copy the full SHA
    fb8ac6b View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    a85ff0a View commit details
    Browse the repository at this point in the history
  7. fix(ci): add unused imports check to ci (ethereum-optimism#12360)

    Adds the Solidity unused imports check to ci.
    smartcontracts authored Oct 7, 2024
    Configuration menu
    Copy the full SHA
    77c91d0 View commit details
    Browse the repository at this point in the history
  8. fix(ci): add MIPSInstructions as exception (ethereum-optimism#12361)

    Adds MIPSInstructions as an exception to malformed require.
    smartcontracts authored Oct 7, 2024
    Configuration menu
    Copy the full SHA
    b4171c3 View commit details
    Browse the repository at this point in the history
  9. OPCM: DepolyOPChain additional testing checks. (ethereum-optimism#12355)

    * OPCM: DepolyOPChain additional testing checks.
    
    * fix: absolute prestate.
    
    * fix: adding to assertions.
    
    * fix: maxClockDuration check added.
    blmalone authored Oct 7, 2024
    Configuration menu
    Copy the full SHA
    078e016 View commit details
    Browse the repository at this point in the history
  10. devnet: fix build issue (ethereum-optimism#12364)

    It began to error after ethereum-optimism#12336
    tynes authored Oct 7, 2024
    Configuration menu
    Copy the full SHA
    c938fdf View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2024

  1. fix(ct): deploy MIPS2 properly (ethereum-optimism#12365)

    Adds a new configuration to DeployImplementations so that it
    knows which MIPS version to deploy.
    smartcontracts authored Oct 8, 2024
    Configuration menu
    Copy the full SHA
    2412379 View commit details
    Browse the repository at this point in the history
  2. feat: add semgrep-scan-local to justfile (ethereum-optimism#12366)

    Adds semgrep-scan-local to top-level justfile.
    smartcontracts authored Oct 8, 2024
    Configuration menu
    Copy the full SHA
    8cb56d9 View commit details
    Browse the repository at this point in the history
  3. op-program: Avoid parsing op-sepolia and op-mainnet rollup and chain …

    …configs in init() methods (ethereum-optimism#12307)
    
    This was causing op-program to spend cycles parsing the config JSON files to set constants that weren't actually used.
    ajsutton authored Oct 8, 2024
    Configuration menu
    Copy the full SHA
    fb7f306 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2c24e65 View commit details
    Browse the repository at this point in the history
  5. Interop: Update Inputs (rebased) (ethereum-optimism#12204)

    * op-node,op-supervisor: feed local-unsafe/local-safe/l1-finalized data to supervisor
    
    * op-node,op-service,op-e2e: wip, fix interop op-node tests
    
    * post-rebase compilation fixes
    
    * BlockRef
    
    * op-supervisor: fix service test, cleanup todo
    
    * op-supervisor: link TODO comments to issue
    
    * interop: fix e2e action test
    
    ---------
    
    Co-authored-by: protolambda <proto@protolambda.com>
    axelKingsley and protolambda authored Oct 8, 2024
    Configuration menu
    Copy the full SHA
    dee44ec View commit details
    Browse the repository at this point in the history
  6. cannon: Default load-elf to output state.bin.gz (ethereum-optimism#12367

    )
    
    Update README to use singlethreaded-2 since the old singlethreaded likely isn't available if just compiling the latest version.
    ajsutton authored Oct 8, 2024
    Configuration menu
    Copy the full SHA
    117c9a4 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    d37f753 View commit details
    Browse the repository at this point in the history
  8. MTCannon: Fix AssertEVMReverts to correctly construct data (ethereu…

    …m-optimism#12200)
    
    * 1. Added `WithRegisters` for initializing state's `Registers`.
    2. Added `ThreadProofEncoder` helper function to generate `ThreadProof`.
    3. Updated `AssertEVMReverts` to include `statePCs` for multiple memory requirements, added `ProofData` parameter for passing `ThreadProof`, and introduced `expectedReason` parameter for more precise testing.
    4. Revised `TestEVMFault` and `TestEVM_UnsupportedSyscall` test functions to be compatible with `AssertEVMReverts`.
    
    * lint fix and comment fix
    
    * avoid false negatives
    
    * delete WithRegisters && create ProofGenerator
    
    * assert multi outputs
    
    * fix naming issue
    
    * Update cannon/mipsevm/tests/evm_multithreaded_test.go
    
    Nice catch!
    
    Co-authored-by: mbaxter <meredith.a.baxter@gmail.com>
    
    * Small fix
    
    * link check
    
    * make expectedReason a value & delete nil check
    
    ---------
    
    Co-authored-by: mbaxter <meredith.a.baxter@gmail.com>
    joohhnnn and mbaxter authored Oct 8, 2024
    Configuration menu
    Copy the full SHA
    03b526d View commit details
    Browse the repository at this point in the history
  9. feat(ct): port interface checks to go (ethereum-optimism#12335)

    Ports the interface checks command to go. Updates build command
    to execute forge fmt and the interface checks.
    smartcontracts authored Oct 8, 2024
    Configuration menu
    Copy the full SHA
    87d0152 View commit details
    Browse the repository at this point in the history
  10. OPCM: AddressManager and ProxyAdmin assertions. (ethereum-optimism#12370

    )
    
    * OPCM: AddressManager and ProxyAdmin assertions.
    
    * fix: Added logic for proxy types to check implementations.
    
    * fix: touch ups for RDP impl checking.
    
    * fix: fully fledged proxies added to tests because of new assertions.
    
    * fix: removing console2 lib.
    
    * fix: semgrep complaining.
    
    * fix: comment cleanup and logical split to avoid stack too deep error.
    
    * fix: adding comment back in.
    
    * fix: added natspec comments for new DeployUtils functions.
    
    * fix: removed unused imports.
    blmalone authored Oct 8, 2024
    Configuration menu
    Copy the full SHA
    a05feb3 View commit details
    Browse the repository at this point in the history
  11. fix:fix load/store test compatible cannon64 (ethereum-optimism#12345)

    Signed-off-by: Chen Kai <281165273grape@gmail.com>
    GrapeBaBa authored Oct 8, 2024
    Configuration menu
    Copy the full SHA
    52783f0 View commit details
    Browse the repository at this point in the history
  12. feat:add movz/movn mips test (ethereum-optimism#12353)

    Signed-off-by: Chen Kai <281165273grape@gmail.com>
    GrapeBaBa authored Oct 8, 2024
    Configuration menu
    Copy the full SHA
    c55dcd2 View commit details
    Browse the repository at this point in the history
  13. fix(ci): use forge-build in dockerfile (ethereum-optimism#12377)

    Updates the dockerfile for building contracts-bedrock to use
    just forge-build instead of just build since just build now does
    a few other things for the sake of devex.
    smartcontracts authored Oct 8, 2024
    Configuration menu
    Copy the full SHA
    fb62380 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. Configuration menu
    Copy the full SHA
    3122237 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1dafc7c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    111e0f9 View commit details
    Browse the repository at this point in the history
  4. feat(devnet): use eigenda

    - update README
    - create make altda-devnet-up command
    - swap da-server for eigenda-proxy
    - use redis-cache for eigenda-proxy
    
    devnet(high-throughput): change devnetL1-template to use 60M gas with eip1559 elasticity of 2
    samlaf committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    2bd3e06 View commit details
    Browse the repository at this point in the history