Do Not Merge - Convert the runtime and transform stack to Qwen3.6 27B#437
Draft
anupsv wants to merge 9 commits into
Draft
Do Not Merge - Convert the runtime and transform stack to Qwen3.6 27B#437anupsv wants to merge 9 commits into
anupsv wants to merge 9 commits into
Conversation
Drop unused APIs, the BenchmarkPromptPlan pass-through, and a superseded freeze test; centralize transformed-weights byte-limit parsing; symlink CLAUDE.md to AGENTS.md; and fix README local-score wording. Co-authored-by: Cursor <cursoragent@cursor.com>
Delete the manual parallel-correctness probe workflows and combiner script, move gemma-freshvm to ops/, centralize timed-run score evaluation in BenchmarkScore.evaluateTimedRun, and trim worker expert-stats threading. Co-authored-by: Cursor <cursoragent@cursor.com>
The unified score guard must still publish decode/prefill seconds on finite floor failures, matching the pre-refactor in-process benchmark path. Co-authored-by: Cursor <cursoragent@cursor.com>
Restore formatted floor-failure messages, add evaluateTimedRun unit tests, drop an unused loader variable, and refresh stale combine-era comments. Co-authored-by: Cursor <cursoragent@cursor.com>
Drop unused Gemma4Model.layer, per-layer weight materialization helpers, and the orphaned --step-range-output sidecar now that the parallel correctness combiner is gone. Co-authored-by: Cursor <cursoragent@cursor.com>
The ranked pipeline runs serially on one machine, so step-range slicing, base-case-only mode, and zero-step skip paths are dead surface area. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Replace stale multi-VM and timing-only/gates-only machine wording with phased-run terminology; trim retired parallel-pipeline references in workflow, overlay script, and contract tests. Co-authored-by: Cursor <cursoragent@cursor.com>
Replace the Gemma-specific model, harness, artifact contract, and tests with a fail-closed Qwen3.5-architecture implementation for the pinned Qwen3.6 27B 4-bit checkpoint. Keep the library model as the production oracle while adding a hard-disabled, parity-tested editable fast-path scaffold and explicit operator handoff for the still-protected M5/golden migration. Co-authored-by: Cursor <cursoragent@cursor.com>
|
anupsv does not have permission to run Code Reviewer. You can manage permissions in your settings. |
anupsv
marked this pull request as draft
July 12, 2026 01:24
anupsv
force-pushed
the
chore/simplify-tier1-dead-code
branch
from
July 12, 2026 02:08
9dcb0cb to
1b201fe
Compare
anupsv
force-pushed
the
chore/simplify-tier1-dead-code
branch
from
July 12, 2026 07:02
1b201fe to
b0d1651
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mlx-community/Qwen3.6-27B-4bit@c000ac2c…(qwen3_5_textinternally)Qwen35TextModelas the production oracle with strict 64-layer hybrid-cache/config/1,847-tensor validation, explicit Qwen golden identity, explicit local baselines, and fail-closed worker/preflight contractscorrectness_prompts/**, the M5 benchmark workflow/configuration, and protected operator artifacts unchangedTest plan
swift build -c releaseswift test— 378 tests passedMLXFAST_RUN_MLX_RUNTIME_TESTS=1 swift test— 378 tests passedMLXFAST_QWEN_REFERENCE_WEIGHTS_PATHis absentbash -nacross shell scripts, JSON validation, andgit diff --checkcorrectness_prompts/**,.github/workflows/benchmark.yml, orops/m5-bench/**Important scope note
This prepares the codebase but intentionally does not make Qwen officially rankable yet. The protected M5 workflow and correctness artifacts remain Gemma-specific by request, so official Qwen runs must fail closed until the documented operator migration is completed.
Made with Cursor
Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.