fix: adjust staleness check (#213)

Layr-Labs · Mar 19, 2024 · 48e0aec · 48e0aec
1 parent f3b5fca
commit 48e0aec
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/BLSSignatureChecker.sol b/src/BLSSignatureChecker.sol
@@ -190,7 +190,7 @@ contract BLSSignatureChecker is IBLSSignatureChecker {
                 // is within withdrawalDelayBlocks
                 if (_staleStakesForbidden) {
                     require(
-                        registryCoordinator.quorumUpdateBlockNumber(uint8(quorumNumbers[i])) + withdrawalDelayBlocks >= referenceBlockNumber,
+                        registryCoordinator.quorumUpdateBlockNumber(uint8(quorumNumbers[i])) + withdrawalDelayBlocks > referenceBlockNumber,
                         "BLSSignatureChecker.checkSignatures: StakeRegistry updates must be within withdrawalDelayBlocks window"
                     );
                 }

diff --git a/test/unit/BLSSignatureCheckerUnit.t.sol b/test/unit/BLSSignatureCheckerUnit.t.sol
@@ -314,9 +314,10 @@ contract BLSSignatureCheckerUnitTests is BLSMockAVSDeployer {
         }
 
         // move referenceBlockNumber forward to a block number the last block number where the stakes will be considered "not stale"
-        referenceBlockNumber = uint32(stalestUpdateBlock + delegationMock.minWithdrawalDelayBlocks());
+        referenceBlockNumber = uint32(stalestUpdateBlock + delegationMock.minWithdrawalDelayBlocks()) - 1;
         // roll forward to make the reference block number valid
         // we roll to referenceBlockNumber + 1 because the current block number is not a valid reference block
+
         cheats.roll(referenceBlockNumber + 1);
         blsSignatureChecker.checkSignatures(
             msgHash,