Skip to content

fix: natspec strategy factory #660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ypatil12 merged 5 commits into from
Aug 6, 2024
Merged

fix: natspec strategy factory #660

ypatil12 merged 5 commits into from
Aug 6, 2024

Conversation

@ypatil12
Copy link
Collaborator

@ypatil12 ypatil12 commented Aug 5, 2024

No description provided.

@github-actions
Copy link

github-actions bot commented Aug 5, 2024 

Reading tracefile ./lcov.info.pruned
                                             |Lines      |Functions|Branches  
Filename                                       |Rate    Num|Rate  Num|Rate   Num
================================================================================
[src/contracts/]
core/AVSDirectory.sol                          |77.8%    27|77.8%   9|    -    0
core/DelegationManager.sol                     |96.5%   198|92.3%  39|    -    0
core/RewardsCoordinator.sol                    |90.8%   119|81.2%  32|    -    0
core/StrategyManager.sol                       |95.2%    83|95.8%  24|    -    0
libraries/BeaconChainProofs.sol                |94.7%    38|91.7%  12|    -    0
libraries/BytesLib.sol                         | 2.6%   156| 7.1%  14|    -    0
libraries/EIP1271SignatureUtils.sol            | 100%     3| 100%   1|    -    0
libraries/Endian.sol                           | 100%     2| 100%   1|    -    0
libraries/Merkle.sol                           | 100%    38| 100%   5|    -    0
libraries/StructuredLinkedList.sol             | 0.0%    45| 0.0%  19|    -    0
permissions/Pausable.sol                       |95.7%    23|90.9%  11|    -    0
permissions/PauserRegistry.sol                 | 100%    12| 100%   6|    -    0
pods/DelayedWithdrawalRouter.sol               |93.2%    59|85.7%  14|    -    0
pods/EigenPod.sol                              | 100%   145| 100%  33|    -    0
pods/EigenPodManager.sol                       |98.8%    84|89.5%  19|    -    0
strategies/EigenStrategy.sol                   | 0.0%    10| 0.0%   5|    -    0
strategies/StrategyBase.sol                    |90.7%    43|78.9%  19|    -    0
strategies/StrategyBaseTVLLimits.sol           | 100%    12|83.3%   6|    -    0
strategies/StrategyFactory.sol                 |94.3%    35|88.9%   9|    -    0
token/BackingEigen.sol                         |72.0%    25|50.0%  10|    -    0
token/Eigen.sol                                |38.5%    39|50.0%  12|    -    0
utils/UpgradeableSignatureCheckingUtils.sol    | 0.0%     6| 0.0%   4|    -    0
================================================================================
                                       Total:|76.2%  1202|75.0% 304|    -    0

2 similar comments
@github-actions
Copy link

github-actions bot commented Aug 5, 2024 

Reading tracefile ./lcov.info.pruned
                                             |Lines      |Functions|Branches  
Filename                                       |Rate    Num|Rate  Num|Rate   Num
================================================================================
[src/contracts/]
core/AVSDirectory.sol                          |77.8%    27|77.8%   9|    -    0
core/DelegationManager.sol                     |96.5%   198|92.3%  39|    -    0
core/RewardsCoordinator.sol                    |90.8%   119|81.2%  32|    -    0
core/StrategyManager.sol                       |95.2%    83|95.8%  24|    -    0
libraries/BeaconChainProofs.sol                |94.7%    38|91.7%  12|    -    0
libraries/BytesLib.sol                         | 2.6%   156| 7.1%  14|    -    0
libraries/EIP1271SignatureUtils.sol            | 100%     3| 100%   1|    -    0
libraries/Endian.sol                           | 100%     2| 100%   1|    -    0
libraries/Merkle.sol                           | 100%    38| 100%   5|    -    0
libraries/StructuredLinkedList.sol             | 0.0%    45| 0.0%  19|    -    0
permissions/Pausable.sol                       |95.7%    23|90.9%  11|    -    0
permissions/PauserRegistry.sol                 | 100%    12| 100%   6|    -    0
pods/DelayedWithdrawalRouter.sol               |93.2%    59|85.7%  14|    -    0
pods/EigenPod.sol                              | 100%   145| 100%  33|    -    0
pods/EigenPodManager.sol                       |98.8%    84|89.5%  19|    -    0
strategies/EigenStrategy.sol                   | 0.0%    10| 0.0%   5|    -    0
strategies/StrategyBase.sol                    |90.7%    43|78.9%  19|    -    0
strategies/StrategyBaseTVLLimits.sol           | 100%    12|83.3%   6|    -    0
strategies/StrategyFactory.sol                 |94.3%    35|88.9%   9|    -    0
token/BackingEigen.sol                         |72.0%    25|50.0%  10|    -    0
token/Eigen.sol                                |38.5%    39|50.0%  12|    -    0
utils/UpgradeableSignatureCheckingUtils.sol    | 0.0%     6| 0.0%   4|    -    0
================================================================================
                                       Total:|76.2%  1202|75.0% 304|    -    0

@github-actions
Copy link

github-actions bot commented Aug 6, 2024 

Reading tracefile ./lcov.info.pruned
                                             |Lines      |Functions|Branches  
Filename                                       |Rate    Num|Rate  Num|Rate   Num
================================================================================
[src/contracts/]
core/AVSDirectory.sol                          |77.8%    27|77.8%   9|    -    0
core/DelegationManager.sol                     |96.5%   198|92.3%  39|    -    0
core/RewardsCoordinator.sol                    |90.8%   119|81.2%  32|    -    0
core/StrategyManager.sol                       |95.2%    83|95.8%  24|    -    0
libraries/BeaconChainProofs.sol                |94.7%    38|91.7%  12|    -    0
libraries/BytesLib.sol                         | 2.6%   156| 7.1%  14|    -    0
libraries/EIP1271SignatureUtils.sol            | 100%     3| 100%   1|    -    0
libraries/Endian.sol                           | 100%     2| 100%   1|    -    0
libraries/Merkle.sol                           | 100%    38| 100%   5|    -    0
libraries/StructuredLinkedList.sol             | 0.0%    45| 0.0%  19|    -    0
permissions/Pausable.sol                       |95.7%    23|90.9%  11|    -    0
permissions/PauserRegistry.sol                 | 100%    12| 100%   6|    -    0
pods/DelayedWithdrawalRouter.sol               |93.2%    59|85.7%  14|    -    0
pods/EigenPod.sol                              | 100%   145| 100%  33|    -    0
pods/EigenPodManager.sol                       |98.8%    84|89.5%  19|    -    0
strategies/EigenStrategy.sol                   | 0.0%    10| 0.0%   5|    -    0
strategies/StrategyBase.sol                    |90.7%    43|78.9%  19|    -    0
strategies/StrategyBaseTVLLimits.sol           | 100%    12|83.3%   6|    -    0
strategies/StrategyFactory.sol                 |94.3%    35|88.9%   9|    -    0
token/BackingEigen.sol                         |72.0%    25|50.0%  10|    -    0
token/Eigen.sol                                |38.5%    39|50.0%  12|    -    0
utils/UpgradeableSignatureCheckingUtils.sol    | 0.0%     6| 0.0%   4|    -    0
================================================================================
                                       Total:|76.2%  1202|75.0% 304|    -    0

@ypatil12 ypatil12 force-pushed the fix/natpsec-strat-factory branch from 298d030 to 50bd1b4 Compare August 6, 2024 14:53
@ypatil12 ypatil12 merged commit bdfe969 into feat-StrategyFactory Aug 6, 2024
@ypatil12 ypatil12 deleted the fix/natpsec-strat-factory branch August 6, 2024 14:58
@github-actions
Copy link

github-actions bot commented Aug 6, 2024 

Reading tracefile ./lcov.info.pruned
                                             |Lines      |Functions|Branches  
Filename                                       |Rate    Num|Rate  Num|Rate   Num
================================================================================
[src/contracts/]
core/AVSDirectory.sol                          |77.8%    27|77.8%   9|    -    0
core/DelegationManager.sol                     |96.5%   198|92.3%  39|    -    0
core/RewardsCoordinator.sol                    |90.8%   119|81.2%  32|    -    0
core/StrategyManager.sol                       |95.2%    83|95.8%  24|    -    0
libraries/BeaconChainProofs.sol                |94.7%    38|91.7%  12|    -    0
libraries/BytesLib.sol                         | 2.6%   156| 7.1%  14|    -    0
libraries/EIP1271SignatureUtils.sol            | 100%     3| 100%   1|    -    0
libraries/Endian.sol                           | 100%     2| 100%   1|    -    0
libraries/Merkle.sol                           | 100%    38| 100%   5|    -    0
libraries/StructuredLinkedList.sol             | 0.0%    45| 0.0%  19|    -    0
permissions/Pausable.sol                       |95.7%    23|90.9%  11|    -    0
permissions/PauserRegistry.sol                 | 100%    12| 100%   6|    -    0
pods/DelayedWithdrawalRouter.sol               |93.2%    59|85.7%  14|    -    0
pods/EigenPod.sol                              | 100%   145| 100%  33|    -    0
pods/EigenPodManager.sol                       |98.8%    84|89.5%  19|    -    0
strategies/EigenStrategy.sol                   | 0.0%    10| 0.0%   5|    -    0
strategies/StrategyBase.sol                    |90.9%    44|78.9%  19|    -    0
strategies/StrategyBaseTVLLimits.sol           | 100%    12|83.3%   6|    -    0
strategies/StrategyFactory.sol                 |94.3%    35|88.9%   9|    -    0
token/BackingEigen.sol                         |72.0%    25|50.0%  10|    -    0
token/Eigen.sol                                |38.5%    39|50.0%  12|    -    0
utils/UpgradeableSignatureCheckingUtils.sol    | 0.0%     6| 0.0%   4|    -    0
================================================================================
                                       Total:|76.2%  1203|75.0% 304|    -    0

1 similar comment
@github-actions
Copy link

github-actions bot commented Aug 6, 2024 

Reading tracefile ./lcov.info.pruned
                                             |Lines      |Functions|Branches  
Filename                                       |Rate    Num|Rate  Num|Rate   Num
================================================================================
[src/contracts/]
core/AVSDirectory.sol                          |77.8%    27|77.8%   9|    -    0
core/DelegationManager.sol                     |96.5%   198|92.3%  39|    -    0
core/RewardsCoordinator.sol                    |90.8%   119|81.2%  32|    -    0
core/StrategyManager.sol                       |95.2%    83|95.8%  24|    -    0
libraries/BeaconChainProofs.sol                |94.7%    38|91.7%  12|    -    0
libraries/BytesLib.sol                         | 2.6%   156| 7.1%  14|    -    0
libraries/EIP1271SignatureUtils.sol            | 100%     3| 100%   1|    -    0
libraries/Endian.sol                           | 100%     2| 100%   1|    -    0
libraries/Merkle.sol                           | 100%    38| 100%   5|    -    0
libraries/StructuredLinkedList.sol             | 0.0%    45| 0.0%  19|    -    0
permissions/Pausable.sol                       |95.7%    23|90.9%  11|    -    0
permissions/PauserRegistry.sol                 | 100%    12| 100%   6|    -    0
pods/DelayedWithdrawalRouter.sol               |93.2%    59|85.7%  14|    -    0
pods/EigenPod.sol                              | 100%   145| 100%  33|    -    0
pods/EigenPodManager.sol                       |98.8%    84|89.5%  19|    -    0
strategies/EigenStrategy.sol                   | 0.0%    10| 0.0%   5|    -    0
strategies/StrategyBase.sol                    |90.9%    44|78.9%  19|    -    0
strategies/StrategyBaseTVLLimits.sol           | 100%    12|83.3%   6|    -    0
strategies/StrategyFactory.sol                 |94.3%    35|88.9%   9|    -    0
token/BackingEigen.sol                         |72.0%    25|50.0%  10|    -    0
token/Eigen.sol                                |38.5%    39|50.0%  12|    -    0
utils/UpgradeableSignatureCheckingUtils.sol    | 0.0%     6| 0.0%   4|    -    0
================================================================================
                                       Total:|76.2%  1203|75.0% 304|    -    0

wadealexc pushed a commit that referenced this pull request Aug 7, 2024
@ChaoticWalrus @wadealexc
feat: implement permissionless strategy deployment
0960524 
* fix: make the StrategyFactory actually whitelist new strategies

* feat: add several unit tests for the StrategyFactory

* feat: switch to beacon proxies

* feat: split storage, create interface, and rename

- separate storage contract

- create interface -- storage contract inherits from it

- rename `tokenStrategies` => `tokenStrategy` for clarity

* chore: move events to interface

* feat: additional unit tests, interface cleanup

* feat: reduce owner powers, make mapping behavior strict

- remove `editTokenStrategiesMapping` and `setStrategyBeacon` functions

- make the `whitelistStrategies` pass-through function no longer edit the `tokenStrategy` mapping

- delete and modify related tests, as necessary

* feat: add several unit tests for the StrategyFactory

* feat: switch to beacon proxies

* feat: additional unit tests, interface cleanup

* feat: reduce owner powers, make mapping behavior strict

- remove `editTokenStrategiesMapping` and `setStrategyBeacon` functions

- make the `whitelistStrategies` pass-through function no longer edit the `tokenStrategy` mapping

- delete and modify related tests, as necessary

* chore: formatting

feat: add `blacklistTokens` fn

refactor: separate mapping

Feat: add `sharesToUnderlying` event (#644)

* feat: add `sharesToUnderlying` event

* refactor: cleanup

* refactor: separate logic to new fn

* test: sanity

feat: emit exchange rate on deposits/withdrawals (#647)

* feat: exchange rate in deposits/withdrawals

* chore: forge fmt

---------

Co-authored-by: clandestine.eth <96172957+0xClandestine@users.noreply.github.com>

fix: strategy unit tests

feat: add pass thoughts for all `strategyWhitelister` gated functions (#648)

docs: add documentation for strategy factory methods

chore: make bindings

feat: change name of tokenStrategy mapping to deployedStrategies (#657)

feat: auto remove strategies from whitelist (#658)

feat: limit total shares on `StrategyBase` (#659)

* feat: limit totalShares

* chore: update natspec

* chore: bindings & formatting

* chore: bindings

* docs: update docs with max total shares change

* chore: fix formatting

---------

Co-authored-by: wadealexc <pragma-services@proton.me>

fix: natspec strategy factory (#660)

* fix: natspec

* chore: format

* chore: bindings

* chore: bindings

* chore: bindings

feat: integration tests

docs: wip readme update

docs: finalize deployment info in readme
wadealexc pushed a commit that referenced this pull request Aug 7, 2024
@ChaoticWalrus @wadealexc
feat: implement permissionless strategy deployment
b8694e9 
* fix: make the StrategyFactory actually whitelist new strategies

* feat: add several unit tests for the StrategyFactory

* feat: switch to beacon proxies

* feat: split storage, create interface, and rename

- separate storage contract

- create interface -- storage contract inherits from it

- rename `tokenStrategies` => `tokenStrategy` for clarity

* chore: move events to interface

* feat: additional unit tests, interface cleanup

* feat: reduce owner powers, make mapping behavior strict

- remove `editTokenStrategiesMapping` and `setStrategyBeacon` functions

- make the `whitelistStrategies` pass-through function no longer edit the `tokenStrategy` mapping

- delete and modify related tests, as necessary

* feat: add several unit tests for the StrategyFactory

* feat: switch to beacon proxies

* feat: additional unit tests, interface cleanup

* feat: reduce owner powers, make mapping behavior strict

- remove `editTokenStrategiesMapping` and `setStrategyBeacon` functions

- make the `whitelistStrategies` pass-through function no longer edit the `tokenStrategy` mapping

- delete and modify related tests, as necessary

* chore: formatting

feat: add `blacklistTokens` fn

refactor: separate mapping

Feat: add `sharesToUnderlying` event (#644)

* feat: add `sharesToUnderlying` event

* refactor: cleanup

* refactor: separate logic to new fn

* test: sanity

feat: emit exchange rate on deposits/withdrawals (#647)

* feat: exchange rate in deposits/withdrawals

* chore: forge fmt

---------

Co-authored-by: clandestine.eth <96172957+0xClandestine@users.noreply.github.com>

fix: strategy unit tests

feat: add pass thoughts for all `strategyWhitelister` gated functions (#648)

docs: add documentation for strategy factory methods

chore: make bindings

feat: change name of tokenStrategy mapping to deployedStrategies (#657)

feat: auto remove strategies from whitelist (#658)

feat: limit total shares on `StrategyBase` (#659)

* feat: limit totalShares

* chore: update natspec

* chore: bindings & formatting

* chore: bindings

* docs: update docs with max total shares change

* chore: fix formatting

---------

Co-authored-by: wadealexc <pragma-services@proton.me>

fix: natspec strategy factory (#660)

* fix: natspec

* chore: format

* chore: bindings

* chore: bindings

* chore: bindings

feat: integration tests

docs: wip readme update

docs: finalize deployment info in readme
wadealexc pushed a commit that referenced this pull request Aug 7, 2024
@ChaoticWalrus
feat: implement permissionless strategy deployment (#522)
d3730b5 
* fix: make the StrategyFactory actually whitelist new strategies

* feat: add several unit tests for the StrategyFactory

* feat: switch to beacon proxies

* feat: split storage, create interface, and rename

- separate storage contract

- create interface -- storage contract inherits from it

- rename `tokenStrategies` => `tokenStrategy` for clarity

* chore: move events to interface

* feat: additional unit tests, interface cleanup

* feat: reduce owner powers, make mapping behavior strict

- remove `editTokenStrategiesMapping` and `setStrategyBeacon` functions

- make the `whitelistStrategies` pass-through function no longer edit the `tokenStrategy` mapping

- delete and modify related tests, as necessary

* feat: add several unit tests for the StrategyFactory

* feat: switch to beacon proxies

* feat: additional unit tests, interface cleanup

* feat: reduce owner powers, make mapping behavior strict

- remove `editTokenStrategiesMapping` and `setStrategyBeacon` functions

- make the `whitelistStrategies` pass-through function no longer edit the `tokenStrategy` mapping

- delete and modify related tests, as necessary

* chore: formatting

feat: add `blacklistTokens` fn

refactor: separate mapping

Feat: add `sharesToUnderlying` event (#644)

* feat: add `sharesToUnderlying` event

* refactor: cleanup

* refactor: separate logic to new fn

* test: sanity

feat: emit exchange rate on deposits/withdrawals (#647)

* feat: exchange rate in deposits/withdrawals

* chore: forge fmt

---------

Co-authored-by: clandestine.eth <96172957+0xClandestine@users.noreply.github.com>

fix: strategy unit tests

feat: add pass thoughts for all `strategyWhitelister` gated functions (#648)

docs: add documentation for strategy factory methods

chore: make bindings

feat: change name of tokenStrategy mapping to deployedStrategies (#657)

feat: auto remove strategies from whitelist (#658)

feat: limit total shares on `StrategyBase` (#659)

* feat: limit totalShares

* chore: update natspec

* chore: bindings & formatting

* chore: bindings

* docs: update docs with max total shares change

* chore: fix formatting

---------

Co-authored-by: wadealexc <pragma-services@proton.me>

fix: natspec strategy factory (#660)

* fix: natspec

* chore: format

* chore: bindings

* chore: bindings

* chore: bindings

feat: integration tests

docs: wip readme update

docs: finalize deployment info in readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@wadealexc wadealexc wadealexc approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ypatil12 @wadealexc