fix(docs): correct hash value in natspec #1587
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nadir-akhtar
changed the base branch from
main
to
release-dev/multichain-pt2-audit-fixes
nadir-akhtar
changed the title
nadir-akhtar
force-pushed
the
nadir/leaf-calculator-mixin-typo
branch
from
910cc28 to
1e580b4
Compare
ypatil12
approved these changes
Aug 4, 2025
eigenmikem
approved these changes
Aug 4, 2025
nadir-akhtar
merged commit 73f1662
into
release-dev/multichain-pt2-audit-fixes
9 checks passed
ypatil12
pushed a commit
that referenced
this pull request
Aug 8, 2025
<!--
🚨 ATTENTION! 🚨
This PR template is REQUIRED. PRs not following this format will be
closed without review.
Requirements:
- PR title must follow commit conventions:
https://www.conventionalcommits.org/en/v1.0.0/
- Label your PR with the correct type (e.g., 🐛 Bug, ✨ Enhancement, 🧪
Test, etc.)
- Provide clear and specific details in each section
-->
**Motivation:**
Small typo in natspec regarding hash value. The value in the code is
correct, but the docs are not.
**Modifications:**
* Fixed value in documentation for how salts were derived
**Result:**
More accurate docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Small typo in natspec regarding hash value. The value in the code is correct, but the docs are not.
Modifications:
Result:
More accurate docs