fix: overwriting existing pending modifications #1052
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
|
ypatil12
approved these changes
Jan 29, 2025
Collaborator
ypatil12
left a comment
ypatil12
left a comment
There was a problem hiding this comment.
LGTM, had a test question
| cheats.expectRevert(ModificationAlreadyPending.selector); | ||
| allocationManager.modifyAllocations(defaultOperator, newAllocateParams1); | ||
|
|
||
| // Assert that the deallocationQueue is unordered for the 2 deallocations in queue |
| * | ||
| * This test checks that the deallocationQueue is ascending ordered by effectBlocks | ||
| * In this case the new modifyAllocations call is an allocation | ||
| * where the effectBlock is increased and the deallocationQueue is unordered as well because the operator |
wadealexc
force-pushed
the
fix-pending-diff-bug
branch
from
22ab594 to
1035d9c
Compare
wadealexc
approved these changes
Jan 30, 2025
8sunyuan
force-pushed
the
fix-pending-diff-bug
branch
from
1035d9c to
04526ba
Compare
0xClandestine
pushed a commit
that referenced
this pull request
Feb 11, 2025
* test: regression tests showing invalid state * fix: require check and update tests
ypatil12
pushed a commit
that referenced
this pull request
Feb 19, 2025
* test: regression tests showing invalid state * fix: require check and update tests
ypatil12
pushed a commit
that referenced
this pull request
Feb 20, 2025
* test: regression tests showing invalid state * fix: require check and update tests
ypatil12
pushed a commit
that referenced
this pull request
Feb 20, 2025
* test: regression tests showing invalid state * fix: require check and update tests
ypatil12
pushed a commit
that referenced
this pull request
Feb 20, 2025
* test: regression tests showing invalid state * fix: require check and update tests
ypatil12
pushed a commit
that referenced
this pull request
Feb 20, 2025
* test: regression tests showing invalid state * fix: require check and update tests
ypatil12
pushed a commit
that referenced
this pull request
Feb 20, 2025
* test: regression tests showing invalid state * fix: require check and update tests
ypatil12
pushed a commit
that referenced
this pull request
Feb 20, 2025
* test: regression tests showing invalid state * fix: require check and update tests
ypatil12
pushed a commit
that referenced
this pull request
Feb 20, 2025
* test: regression tests showing invalid state * fix: require check and update tests
ypatil12
pushed a commit
that referenced
this pull request
Feb 20, 2025
* test: regression tests showing invalid state * fix: require check and update tests
ypatil12
pushed a commit
that referenced
this pull request
Feb 20, 2025
* test: regression tests showing invalid state * fix: require check and update tests
ypatil12
pushed a commit
that referenced
this pull request
Feb 20, 2025
* test: regression tests showing invalid state * fix: require check and update tests
ypatil12
pushed a commit
that referenced
this pull request
Feb 20, 2025
* test: regression tests showing invalid state * fix: require check and update tests
ypatil12
pushed a commit
that referenced
this pull request
Feb 20, 2025
* test: regression tests showing invalid state * fix: require check and update tests
ypatil12
pushed a commit
that referenced
this pull request
Feb 20, 2025
* test: regression tests showing invalid state * fix: require check and update tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a result of an existing deallocation being slashed such that its pendingDiff becomes an amount 0, it is possible
to call modifyAllocations and create a new allocation/deallocation overwriting the old deallocation in storage.
This could result in the deallocationQueue no longer being in ascending order by the deallocation's respective effectBlocks.
This prevents this edge case altogether by simply changing the check to use the effectBlock instead
require(allocation.effectBlock == 0, ModificationAlreadyPending());