fix: overflow bug for pendingDiff input #1027
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8sunyuan
changed the base branch from
slashing-magnitudes
to
slashing-magnitudes-fixes
wadealexc
force-pushed
the
fix-overflow-bug
branch
from
cdeaf5b to
9b144d9
Compare
wadealexc
force-pushed
the
fix-overflow-bug
branch
from
9b144d9 to
656e49c
Compare
ypatil12
approved these changes
Jan 30, 2025
0xClandestine
pushed a commit
that referenced
this pull request
Feb 11, 2025
* fix: overflow bug for pendingDiff input * test: add check to regression test --------- Co-authored-by: wadealexc <pragma-services@proton.me>
ypatil12
pushed a commit
that referenced
this pull request
Feb 19, 2025
* fix: overflow bug for pendingDiff input * test: add check to regression test --------- Co-authored-by: wadealexc <pragma-services@proton.me>
ypatil12
pushed a commit
that referenced
this pull request
Feb 20, 2025
* fix: overflow bug for pendingDiff input * test: add check to regression test --------- Co-authored-by: wadealexc <pragma-services@proton.me>
ypatil12
pushed a commit
that referenced
this pull request
Feb 20, 2025
* fix: overflow bug for pendingDiff input * test: add check to regression test --------- Co-authored-by: wadealexc <pragma-services@proton.me>
ypatil12
pushed a commit
that referenced
this pull request
Feb 20, 2025
* fix: overflow bug for pendingDiff input * test: add check to regression test --------- Co-authored-by: wadealexc <pragma-services@proton.me>
ypatil12
pushed a commit
that referenced
this pull request
Feb 20, 2025
* fix: overflow bug for pendingDiff input * test: add check to regression test --------- Co-authored-by: wadealexc <pragma-services@proton.me>
ypatil12
pushed a commit
that referenced
this pull request
Feb 20, 2025
* fix: overflow bug for pendingDiff input * test: add check to regression test --------- Co-authored-by: wadealexc <pragma-services@proton.me>
ypatil12
pushed a commit
that referenced
this pull request
Feb 20, 2025
* fix: overflow bug for pendingDiff input * test: add check to regression test --------- Co-authored-by: wadealexc <pragma-services@proton.me>
ypatil12
pushed a commit
that referenced
this pull request
Feb 20, 2025
* fix: overflow bug for pendingDiff input * test: add check to regression test --------- Co-authored-by: wadealexc <pragma-services@proton.me>
ypatil12
pushed a commit
that referenced
this pull request
Feb 20, 2025
* fix: overflow bug for pendingDiff input * test: add check to regression test --------- Co-authored-by: wadealexc <pragma-services@proton.me>
ypatil12
pushed a commit
that referenced
this pull request
Feb 20, 2025
* fix: overflow bug for pendingDiff input * test: add check to regression test --------- Co-authored-by: wadealexc <pragma-services@proton.me>
ypatil12
pushed a commit
that referenced
this pull request
Feb 20, 2025
* fix: overflow bug for pendingDiff input * test: add check to regression test --------- Co-authored-by: wadealexc <pragma-services@proton.me>
ypatil12
pushed a commit
that referenced
this pull request
Feb 20, 2025
* fix: overflow bug for pendingDiff input * test: add check to regression test --------- Co-authored-by: wadealexc <pragma-services@proton.me>
ypatil12
pushed a commit
that referenced
this pull request
Feb 20, 2025
* fix: overflow bug for pendingDiff input * test: add check to regression test --------- Co-authored-by: wadealexc <pragma-services@proton.me>
ypatil12
pushed a commit
that referenced
this pull request
Feb 20, 2025
* fix: overflow bug for pendingDiff input * test: add check to regression test --------- Co-authored-by: wadealexc <pragma-services@proton.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to casting not causing a revert in
_addInt128, its possible to cast and truncate a value that overflows. This introduces several problems but the one outlined in the added test shows you can manipulate encumberedMagnitude to be 0 and infinitely allocate instead of being capped by maxMagnitude.This simple fix will now safecast and cause a revert if overflow occurs when downcasting to a
uint64. If needed, we can only add a check on the input param so that the new magnitude allocation is <= WAD