Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v2] payments inabox #991

Merged
merged 43 commits into from
Dec 20, 2024
Merged

[v2] payments inabox #991

merged 43 commits into from
Dec 20, 2024

Conversation

hopeyen
Copy link
Contributor

@hopeyen hopeyen commented Dec 12, 2024

Why are these changes needed?

enabling inabox with payments

Checks

  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • I've checked the new test coverage and the coverage percentage didn't drop.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@hopeyen hopeyen changed the title temp: uncomment payment construction [v2] payments inabox Dec 12, 2024
@hopeyen hopeyen force-pushed the hope/payments-v2-inabox branch 23 times, most recently from 1bf965f to d69ffc2 Compare December 14, 2024 04:40
@hopeyen hopeyen changed the base branch from master to hope/new-payments-contract December 14, 2024 04:40
@hopeyen hopeyen force-pushed the hope/payments-v2-inabox branch 4 times, most recently from f9ec220 to 7c67725 Compare December 14, 2024 18:28
Base automatically changed from hope/new-payments-contract to master December 16, 2024 18:42
hopeyen and others added 27 commits December 19, 2024 19:17
@hopeyen
temp: lots of debug logs and hardcoding, getting context deadline
cba9030
@hopeyen
temp: still context deadline
50e8034
@hopeyen
test: initially working reservation e2e test!
ade9e97
@hopeyen
refactor: dummy accountant and use getters
c4b350e
@hopeyen
contracts: ondemand deposit tx
17e7711
@hopeyen
fix: dummy accountant with empty on-chain status
88cd0a1
@hopeyen
refactor: remove redundant debugging logs
da417ce
@hopeyen
fix: handle zero value empty slices
7dbc4b2
@hopeyen
feat: client keys setup
7b934f0
@hopeyen
refactor: minor cleanup
59ad101
@hopeyen
fix: offchain store in setup
7f0b3ab
@hopeyen
fix: comment out commitment check in mock rollup
c4ebc95
@hopeyen
chore: logs and comments
3ba54f2
@hopeyen
feat: init once populate accountant in disperseBlob
cd06a17
@hopeyen
test: initially working reservation e2e test!
eb9b8c6
@hopeyen
refactor: dummy accountant and use getters
be62606
@hopeyen
refactor: remove redundant debugging logs
11218d9
@hopeyen
fix: handle zero value empty slices
4c7e644
@hopeyen
refactor: minor cleanup
e2756e2
@hopeyen
refactor: locks
d501688
@hopeyen
refactor: cleanups and logs
9fbb3bf
@hopeyen
fix: db exist check
149c28b
@hopeyen
fix: reorder auth checks for tests
b79a4f5
@hopeyen
refactor: remove DummyAccountant
f5bae11
@hopeyen
chore: undo debug/temp changes
4bd75a0
@hopeyen
fix: unit tests
4ac8b22
@hopeyen
rftr: send on payments as owner
ea6fe9b
@hopeyen hopeyen force-pushed the hope/payments-v2-inabox branch from 1a5854f to ea6fe9b Compare December 20, 2024 03:20
@hopeyen hopeyen merged commit 6059c6a into master Dec 20, 2024
10 checks passed
@hopeyen hopeyen deleted the hope/payments-v2-inabox branch December 20, 2024 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x0aa0 0x0aa0 0x0aa0 left review comments

@ian-shim ian-shim ian-shim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hopeyen @0x0aa0 @ian-shim