-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement v2 client GET functionality #972
Merged
+1,062
−67
Merged
Changes from 1 commit
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
4625e96
Write GET tests
litt3 f07e820
Merge branch 'master' into client-v2-get
litt3 885c131
Respond to PR comments
litt3 6848663
Create new V2 client config
litt3 a48afb1
Respond to more PR comments
litt3 225f2a3
Fix failing unit test
litt3 d265f6a
Merge branch 'master' into client-v2-get
litt3 e9d91c5
Adopt new package structure
litt3 dd3c262
Use new test random util
litt3 88df865
Implement relay call timeout
litt3 505a1f0
Use correct error join method
litt3 2b87633
Merge branch 'master' into client-v2-get
litt3 cf1cd80
Make updates required by upstream changes
litt3 53893d8
Update how FFT and IFFT are referred to
litt3 0373dd7
Implement GetPayload
litt3 826a026
Remove GetBlob, leaving only GetPayload
litt3 975b6e5
Remove unnecessary codec mock
litt3 0666d24
Use more reasonable line breaks for logs
litt3 0a49aa5
Test malicious cert
litt3 1193ce7
Merge branch 'master' into client-v2-get
litt3 496e277
Merge branch 'master' into client-v2-get
litt3 2d392ff
Finish test coverage
litt3 db51291
Fix commitment length check
litt3 4f3280c
Merge branch 'master' into client-v2-get
litt3 aaa1342
Call VerifyBlobV2
litt3 9be51e6
Simply verify blob
litt3 cc6b9a1
Merge branch 'master' into client-v2-get
litt3 ae926c7
Clean up
litt3 f82d128
Merge branch 'master' into client-v2-get
litt3 017a48c
Return error from verification method
litt3 b645370
Merge branch 'master' into client-v2-get
litt3 03f8018
Address some PR comments
litt3 ef3944d
Rename methods, and clean up
litt3 78cab0d
Actually apply fix for poor doc
litt3 e27d3ea
Fix goroutine safety comment
litt3 f6126af
Merge branch 'master' into client-v2-get
litt3 28c3d02
Fix test
litt3 036a222
Rework polynomial encoding enum, and descriptions
litt3 7b66df6
Make PR fixes
litt3 ad3dc97
Move conversion utils
litt3 6930a47
Remove GetCodec
litt3 ec190ca
Merge branch 'master' into client-v2-get
litt3 d27c463
Merge branch 'master' into client-v2-get
litt3 840ca9a
Fix merge
litt3 16f0c74
Add additional comment about random
litt3 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Test malicious cert
Signed-off-by: litt3 <102969658+litt3@users.noreply.github.com>
commit 0a49aa58ee7a3075a912c7b4f6ccbeebdeb472f0
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Access has been restricted
You have triggered a rate limit.
Please wait a few minutes before you try again;
in some cases this may take up to an hour.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this error a terminal one but others warrant retrying? Is the idea that if a blob passes verification then the contents would always be the same and therefore the codec decoding would yield the same result irrespective of relay?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e.g couldn't only one relay lie about the length of the blob, causing the initial varuint decoding and length invariant to fail?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct. If the blob contents verified against the cert we have, that means the relay delivered the blob as it was dispersed. If we asked another relay, either it would:
If a non-parseable blob verifies against the commitments, time to panic. Either it's a bug, or worse