Do not fail the object fetch when object size is unknown #932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmanc
approved these changes
Nov 25, 2024
common/aws/s3/client.go
Outdated
| size, err := PeekObjectSize(ctx, s.s3Client, bucket, key) | ||
| if err != nil { | ||
| return nil, err | ||
| objectSize := 128 * 1024 |
There was a problem hiding this comment.
How was this number chosen? Also should make it a const
There was a problem hiding this comment.
Just give it a moderate number so it won't waste a lot, nor need to realloc the memory too many times.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
If it fails to peek the object size, we just use a default size and continue to download the blob (instead of failing it).
Checks