Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More minibatch clean up #883

Merged
merged 1 commit into from
Nov 13, 2024
Merged

More minibatch clean up #883

merged 1 commit into from
Nov 13, 2024

Conversation

ian-shim
Copy link
Contributor

Why are these changes needed?

Cleaning up more methods that are not to be used

Checks

  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • I've checked the new test coverage and the coverage percentage didn't drop.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@ian-shim ian-shim requested review from pschork and jianoaix November 11, 2024 23:32
@ian-shim ian-shim marked this pull request as ready for review November 11, 2024 23:51
@ian-shim ian-shim force-pushed the more-minibatch-cleanup branch from c34772e to 9db0ca3 Compare November 13, 2024 01:59
@ian-shim ian-shim merged commit c694d41 into Layr-Labs:master Nov 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jianoaix jianoaix jianoaix approved these changes

@mooselumph mooselumph mooselumph approved these changes

@pschork pschork pschork approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ian-shim @pschork @mooselumph @jianoaix