Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v2 BlobMetadataStore operations for BlobVerificationInfos #878

Merged
merged 1 commit into from
Nov 11, 2024
Merged

v2 BlobMetadataStore operations for BlobVerificationInfos #878

merged 1 commit into from
Nov 11, 2024

Conversation

ian-shim
Copy link
Contributor

@ian-shim ian-shim commented Nov 8, 2024

Why are these changes needed?

  • Adds metadata store operations related to BlobVerificationInfo including a batch write operation
  • Adds a mock DynamoDB client for testing batch write operation

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • I've checked the new test coverage and the coverage percentage didn't drop.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

ian-shim
ian-shim commented Nov 8, 2024
View reviewed changes
disperser/common/v2/blobstore/dynamo_metadata_store.go
@@ -422,6 +423,107 @@ func (s *BlobMetadataStore) GetAttestation(ctx context.Context, batchHeaderHash
return attestation, nil
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Primary changes are in this file

@ian-shim ian-shim marked this pull request as ready for review November 8, 2024 23:38
@ian-shim ian-shim requested a review from anupsv November 8, 2024 23:45
@ian-shim ian-shim mentioned this pull request Nov 8, 2024
Merged
6 tasks
@ian-shim ian-shim merged commit 3453468 into Layr-Labs:master Nov 11, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mooselumph mooselumph mooselumph approved these changes

@cody-littley cody-littley Awaiting requested review from cody-littley

@anupsv anupsv Awaiting requested review from anupsv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ian-shim @mooselumph