verifyBlobs util #862
Merged
verifyBlobs util #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpsanant
reviewed
Nov 15, 2024
| */ | ||
| function verifyBlobs( | ||
| IEigenDAServiceManager.BlobHeader[] calldata blobHeaders, | ||
| IEigenDAServiceManager eigenDAServiceManager, |
gpsanant
reviewed
Nov 15, 2024
| Merkle.verifyInclusionKeccak( | ||
| blobVerificationProofs[i].inclusionProof, | ||
| blobVerificationProofs[i].batchMetadata.batchHeader.blobHeadersRoot, | ||
| keccak256(abi.encodePacked(EigenDAHasher.hashBlobHeader(blobHeaders[i]))), |
gpsanant
reviewed
Nov 15, 2024
|
|
||
| // make sure that the adversaryThresholdPercentage is at least the given quorumAdversaryThresholdPercentage | ||
| uint8 _adversaryThresholdPercentage = uint8(quorumAdversaryThresholdPercentages[blobHeaders[i].quorumBlobParams[j].quorumNumber]); | ||
| if(_adversaryThresholdPercentage > 0){ |
gpsanant
reviewed
Nov 15, 2024
| ); | ||
|
|
||
| // bitmap of quorum numbers in all quorumBlobParams | ||
| uint256 confirmedQuorumsBitmap; |
There was a problem hiding this comment.
if not, why not just point to the indices in quorumBlobParams to verify?
gpsanant
reviewed
Nov 18, 2024
| @@ -31,10 +31,10 @@ library EigenDARollupUtils { | |||
| * @param blobVerificationProof the relevant data needed to prove inclusion of the blob and that the trust assumptions were as expected | |||
| */ | |||
| function verifyBlob( | |||
| IEigenDAServiceManager.BlobHeader calldata blobHeader, | |||
| IEigenDAServiceManager.BlobHeader memory blobHeader, | |||
gpsanant
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Adds a verifyBlobs function to RollupUtils that accepts input of multiple blob proofs for verification
Checks