Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: remove unneeded lint checkbox in pull_request_template.md #859

Merged
merged 1 commit into from
Nov 9, 2024

Conversation

samlaf
Copy link
Contributor

@samlaf samlaf commented Nov 1, 2024

Why are these changes needed?

Not sure why we have this checkbox since we have a CI action that lints. We should instead just make it impossible to merge a PR where the lint workflow is failing (I can't change these settings because not admin on this repo).

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • I've checked the new test coverage and the coverage percentage didn't drop.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@samlaf samlaf requested review from jianoaix and ian-shim November 1, 2024 19:33
@dmanc
Copy link
Contributor

dmanc commented Nov 7, 2024

We could also shift this further left by using pre-commit hooks

@jianoaix
Copy link
Contributor

jianoaix commented Nov 9, 2024

It's there maybe due to that we were in a unhealthy state long time ago. But sounds fine to make lint non-optional and auto enforced (hence remove it from check box).

@samlaf samlaf merged commit 2c66afc into master Nov 9, 2024
10 checks passed
@samlaf samlaf deleted the samlaf-patch-2 branch November 9, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants