Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] Node Client StoreChunks method #852

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

ian-shim
Copy link
Contributor

Why are these changes needed?

Initial implementation of v2 node client. It only implements StoreChunks method for now.

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • I've checked the new test coverage and the coverage percentage didn't drop.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@ian-shim
Copy link
Contributor Author

To be merged on top of #851

@ian-shim ian-shim changed the title [v2] Node Client [v2] Node Client StoreChunks method Oct 31, 2024
@ian-shim ian-shim marked this pull request as ready for review October 31, 2024 01:31
Comment on lines 1 to 2
package clients_test

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you forgot something here. 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤭 an attempt has been made

@ian-shim ian-shim force-pushed the node-client-v2 branch 4 times, most recently from 75c2576 to 055f0cf Compare November 4, 2024 17:50
@ian-shim ian-shim requested a review from cody-littley November 4, 2024 17:56
@ian-shim
Copy link
Contributor Author

ian-shim commented Nov 5, 2024

To be rebased on top of #864

@ian-shim ian-shim merged commit 4087c4b into Layr-Labs:master Nov 6, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants