Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v2] BlobMetadataStore: Blob Certificate Operations #844

Merged
merged 1 commit into from
Oct 30, 2024
Merged

[v2] BlobMetadataStore: Blob Certificate Operations #844

merged 1 commit into from
Oct 30, 2024

Conversation

ian-shim
Copy link
Contributor

Why are these changes needed?

  • updates conditional puts in dynamodb client
  • refactors put operations in v2 metadata store with conditional
  • adds operations to put/get blob certs

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • I've checked the new test coverage and the coverage percentage didn't drop.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@ian-shim
Copy link
Contributor Author

To be rebased on top of #841

@ian-shim ian-shim marked this pull request as ready for review October 29, 2024 05:22
@ian-shim ian-shim force-pushed the blob-cert-metadata-store branch from 74c15b6 to 09fc8d8 Compare October 29, 2024 17:47
@ian-shim ian-shim mentioned this pull request Oct 30, 2024
Merged
6 tasks
@ian-shim ian-shim merged commit 2ed86a0 into Layr-Labs:master Oct 30, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pschork pschork pschork approved these changes

@mooselumph mooselumph Awaiting requested review from mooselumph

@cody-littley cody-littley Awaiting requested review from cody-littley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ian-shim @pschork