Refactor Transactor into Reader/Writer #832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hopeyen
approved these changes
Oct 23, 2024
core/tx.go
Outdated
| @@ -29,7 +29,7 @@ type OperatorSetParam struct { | |||
|
|
|||
| type OperatorStakes map[QuorumID]map[OperatorIndex]OperatorStake | |||
|
|
|||
| type Transactor interface { | |||
| type TransactorOld interface { | |||
There was a problem hiding this comment.
not deleting this yet? I don't think it is used anywhere
ian-shim
reviewed
Oct 23, 2024
| @@ -12,29 +12,29 @@ import ( | |||
| "github.com/stretchr/testify/mock" | |||
There was a problem hiding this comment.
should this be split into MockWriter and MockReader?
There was a problem hiding this comment.
Since the Writer implements Reader, for mocking purposes it seems fine to combine? What do you think?
There was a problem hiding this comment.
How about having MockReader embedded into MockWriter just like how Writer embeds Reader?
core/tx.go
Outdated
| @@ -29,7 +29,7 @@ type OperatorSetParam struct { | |||
|
|
|||
| type OperatorStakes map[QuorumID]map[OperatorIndex]OperatorStake | |||
|
|
|||
| type Transactor interface { | |||
| type TransactorOld interface { | |||
| } | ||
|
|
||
| func NewChainState(tx core.Transactor, client common.EthClient) *ChainState { | ||
| func NewChainState(tx core.Reader, client common.EthClient) *ChainState { |
There was a problem hiding this comment.
will this be part of Reader down the road?
There was a problem hiding this comment.
I think so. Will be a follow up.
ian-shim
approved these changes
Oct 24, 2024
ian-shim
pushed a commit
to ian-shim/eigenda
that referenced
this pull request
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Breaks transactor into reader/writer
Checks